Unit tests #113
Merged
Unit tests #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added directories for tests
GetByStreetcodeId unit tests
GetAllFacts should return type of List<FactDTO>
Unit tests for Video and Fact part done
Refactoring unit tests for videos handler and facts handlers. Especially refactoring names of tests and also new algorithm for testing delete (fact) handler.
Audio, Streetcodes and RelatedFigure MediatR classes tested.
Unit tests. Not sure in DeleteTextTest especially
changed by request.
An answer for the previous change request. Changed naming and moved setups to private methods.
Change handlers names in tests according to last updates and use namespaces instead of full path to Video entity.
New names for handlers according to last updates. Use namespaces instead of full path to entity Fact.
Considered using some naming conventions. Refactored some comments devoted to current action in tests (Arrange, Act, Assert)
How Nazar said, change multiple Assert with current method Assert.Multiple
refactored everything in general. There were some mistakes.
Refactored (Logic of mocks return now is situated in private static methods). New test added. In case if repo return null handler throw error and now it covered.
Facts refactored and logic with mock returning now outside (in static private function)
Changed files according to the comments.
No comments.
Followed Natalia's advices
Handlers moq now in //Arrange section instead of //Act
This reverts commit d372b59.
This reverts commit dbd0bcc.
This reverts commit 56ed5c6.
…nittests additional-content-unittests
…gure Unit testing: audio/relatedfigure/streeесode
…deoTests Street code/fact and video tests
Up to date test.
Refactored and added all unit tests for Art and Image entities
…itTests Streetcode art&text unit tests
Kasterov
requested review from
Katerix,
Kotusyk,
LanchevychMaxym,
MementoMorj,
NadiaKishchuk,
Tatiana2424 and
Tysyatsky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code reviewers
@LanchevychMaxym
@Tatiana2424
@Katerix
@Tysyatsky
@NadiaKishchuk
@MementoMorj
@EyR1oN
Summary of change
Everything is done and ready for merge. Please, make sure that all tests work properly.