QL: allow prescribed perturbation mode without field file#121
Open
krystophny wants to merge 4 commits into
Open
QL: allow prescribed perturbation mode without field file#121krystophny wants to merge 4 commits into
krystophny wants to merge 4 commits into
Conversation
a97cd17 to
418a190
Compare
Member
Author
|
The |
f6745f0 to
3a34e37
Compare
3a34e37 to
1e7f42f
Compare
isw_qflux_NA=1 with in_file_pert='none' assembles an identically zero non-axisymmetric source. That zero vector is the Arnoldi seed, so its normalization divides by zero (0/0 -> NaN) and zhseqr then fails to converge at every step, spinning without qflux output. Reject the configuration in check() with a clear message instead.
1e7f42f to
9cb8295
Compare
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is stacked on #124 and remains open against
main. PR #120 is already merged.Summary
isw_m_phi_inputandm_phi_inputtontv_inputThe #118 drive is the next stack layer. Its #122 child relaxes the no-source guard only when a nonzero helical source exists. No branch is authorized to merge before the programme-wide gate.
Verification
Test fails on main
With only the regression applied:
Test passes after fix
All 16 external-data regressions remain registered under
regression;external-data; this branch does not mark that separate gate passed.