[ad-16] expose GVEC preconditioner operator#50
Open
krystophny wants to merge 24 commits into
Open
Conversation
Member
Author
|
Fixed AD-16 by adding State.apply_preconditioner(vector), backed by the existing MHD3D preconditioner matrices rather than solver-force evaluation. The operator validates flat-vector layout, preserves the loaded state and input vector, is deterministic and linear on the fixture, and raises UnsupportedFeatureError when PrecondType disables the preconditioner. |
e68d373 to
62d6c2b
Compare
62d6c2b to
f936c8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17.
Expose the current-state GVEC preconditioner as a reusable flat-vector operator:
State.apply_preconditioner(vector)validates the shared flat layout and returns a new transformed vector.q.PrecondType <= 0raise a typedUnsupportedFeatureErrorinstead of silently returning a non-preconditioned solver transform.Verification
Test fails on main
On the parent of this PR branch:
Test passes after fix