[ad-17] add finite-difference residual HVP fallback#51
Open
krystophny wants to merge 25 commits into
Open
Conversation
Member
Author
|
Fixed AD-17 by adding State.hessian_vector_product(..., method="fd") over the public raw residual API. The fallback is explicit, validates vector length before perturbation, preserves state and input vector, returns zero for the zero direction, and rejects non-fd methods so exact Enzyme HVP remains a separate future path. |
8c2776b to
ea4be1a
Compare
ea4be1a to
b678d3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18.
Add a finite-difference Hessian-vector product fallback over the public raw residual API:
State.hessian_vector_product(vector, eps=1e-6, method="fd")returns the centered residual difference at the current state.UnsupportedFeatureError, so the finite-difference path remains explicit and does not pretend to be the future exact Enzyme HVP.Verification
Test fails on main
On the parent of this PR branch:
Test passes after fix