Skip to content

Fix sonarcloud issues#200

Merged
redcatbear merged 3 commits into
developfrom
fix-sonarcloud-issues
Nov 18, 2018
Merged

Fix sonarcloud issues#200
redcatbear merged 3 commits into
developfrom
fix-sonarcloud-issues

Conversation

@kaklakariada

@kaklakariada kaklakariada commented Nov 18, 2018

Copy link
Copy Markdown
Contributor
  • Fix sonar badges and links after sonar project was deleted
  • Fix sonar analysis warnings

@codecov

codecov Bot commented Nov 18, 2018

Copy link
Copy Markdown

Codecov Report

Merging #200 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #200      +/-   ##
=============================================
- Coverage       93.9%   93.89%   -0.01%     
+ Complexity      1045     1042       -3     
=============================================
  Files            109      109              
  Lines           2905     2901       -4     
  Branches         237      237              
=============================================
- Hits            2728     2724       -4     
  Misses           122      122              
  Partials          55       55
Impacted Files Coverage Δ Complexity Δ
...asttrace/core/xml/tree/CallbackContentHandler.java 75.51% <ø> (ø) 17 <0> (ø) ⬇️
...ace/report/view/html/MarkdownLineStateMachine.java 95.77% <ø> (ø) 16 <0> (ø) ⬇️
...trace/report/view/html/MarkdownLineTransition.java 100% <ø> (ø) 7 <0> (ø) ⬇️
...a/org/itsallcode/openfasttrace/ReportSettings.java 96.29% <100%> (ø) 6 <0> (ø) ⬇️
...openfasttrace/importer/tag/TagImporterFactory.java 100% <100%> (ø) 13 <1> (-3) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3912283...3fa9b63. Read the comment docs.

@redcatbear redcatbear mentioned this pull request Nov 18, 2018

@redcatbear redcatbear left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with no findings.

@redcatbear
redcatbear merged commit 06eddba into develop Nov 18, 2018
@redcatbear
redcatbear deleted the fix-sonarcloud-issues branch November 18, 2018 18:19
@redcatbear redcatbear self-assigned this Nov 18, 2018
@redcatbear redcatbear added the bug label Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants