Fix sonarcloud issues

README.md

@@ -17,17 +17,17 @@ You can learn more about requirement tracing and how to use OpenFastTrace in the
 
 Sonarcloud status:
 
-[![Quality Gate](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=alert_status)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Bugs](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=bugs)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Code smells](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=code_smells)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=coverage)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Duplicated Lines](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=duplicated_lines_density)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Lines of Code](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=ncloc)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=sqale_rating)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=reliability_rating)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Security Rating](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=security_rating)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Technical Dept](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=sqale_index)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
-[![Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace%3Adevelop&metric=vulnerabilities)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace%3Adevelop)
+[![Quality Gate](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=alert_status)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Bugs](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=bugs)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Code smells](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=code_smells)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Coverage](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=coverage)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Duplicated Lines](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=duplicated_lines_density)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Lines of Code](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=ncloc)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Maintainability Rating](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=sqale_rating)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Reliability Rating](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=reliability_rating)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Security Rating](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=security_rating)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Technical Dept](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=sqale_index)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
+[![Vulnerabilities](https://sonarcloud.io/api/project_badges/measure?project=org.itsallcode%3Aopenfasttrace&metric=vulnerabilities)](https://sonarcloud.io/dashboard?id=org.itsallcode%3Aopenfasttrace)
 
 * [Blog](https://blog.itsallcode.org/)
 * [Contributing guide](CONTRIBUTING.md)

src/main/java/org/itsallcode/openfasttrace/ReportSettings.java

@@ -110,10 +110,10 @@ public static Builder builder()
      */
     public static class Builder
     {
-        public Newline newline = Newline.UNIX;
-        public String outputFormat = ReportConstants.DEFAULT_REPORT_FORMAT;
-        public boolean showOrigin = false;
-        ReportVerbosity verbosity = ReportVerbosity.FAILURE_DETAILS;
+        private Newline newline = Newline.UNIX;
+        private String outputFormat = ReportConstants.DEFAULT_REPORT_FORMAT;
+        private boolean showOrigin = false;
+        private ReportVerbosity verbosity = ReportVerbosity.FAILURE_DETAILS;
 
         private Builder()
         {

src/main/java/org/itsallcode/openfasttrace/core/xml/tree/CallbackContentHandler.java

@@ -25,6 +25,7 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.function.Consumer;
+import java.util.function.IntConsumer;
 import java.util.function.Supplier;
 import java.util.logging.Logger;
 
@@ -126,7 +127,7 @@ public void pushDelegate(final TreeContentHandler delegate)
     }
 
     public CallbackContentHandler addIntDataListener(final String elementName,
-            final Consumer<Integer> listener)
+            final IntConsumer listener)
     {
         addCharacterDataListener(elementName, data -> {
             if (data == null || data.isEmpty())

src/main/java/org/itsallcode/openfasttrace/importer/tag/TagImporterFactory.java

@@ -3,7 +3,6 @@
 import static java.util.stream.Collectors.toList;
 
 import java.util.Optional;
-import java.util.logging.Logger;
 import java.util.regex.Pattern;
 import java.util.stream.Stream;
 
@@ -39,8 +38,6 @@
 // [impl->dsn~import.full-coverage-tag~1]
 public class TagImporterFactory extends ImporterFactory
 {
-    private static final Logger LOG = Logger.getLogger(TagImporterFactory.class.getName());
-
     private static final String DEFAULT_FILE_REGEX = "(?i).*\\.java";
     private static final Pattern DEFAULT_FILE_PATTERN = Pattern.compile(DEFAULT_FILE_REGEX);
 
@@ -62,11 +59,8 @@ public boolean supportsDefaultFile(final InputFile file)
 
     private Optional<PathConfig> findConfig(final InputFile file)
     {
-        return getPathConfigs()//
-                .peek(config -> LOG
-                        .finest(() -> "Checking config " + config + " with file " + file))
+        return getPathConfigs() //
                 .filter(config -> config.matches(file)) //
-                .peek(config -> LOG.finest(() -> "Config " + config + " matches file " + file)) //
                 .findFirst();
     }
 

src/main/java/org/itsallcode/openfasttrace/report/view/html/MarkdownLineStateMachine.java

@@ -26,7 +26,7 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.function.Function;
+import java.util.function.UnaryOperator;
 
 public class MarkdownLineStateMachine
 {
@@ -85,7 +85,7 @@ protected void initializeTransitions()
     }
 
     private void t(final MarkdownLineState from, final MarkdownLineState to, final String pattern,
-            final String postfix, final String prefix, final Function<String, String> conversion)
+            final String postfix, final String prefix, final UnaryOperator<String> conversion)
     {
         this.transitions
                 .add(new MarkdownLineTransition(from, to, pattern, prefix, postfix, conversion));
@@ -139,22 +139,22 @@ protected void closeLastLineState(final StringBuilder builder, final MarkdownLin
         }
     }
 
-    protected Function<String, String> empty()
+    protected UnaryOperator<String> empty()
     {
         return s -> "";
     }
 
-    protected Function<String, String> trimEnum()
+    protected UnaryOperator<String> trimEnum()
     {
         return s -> s.substring(s.indexOf('.') + 1).trim();
     }
 
-    protected Function<String, String> trimPre()
+    protected UnaryOperator<String> trimPre()
     {
         return s -> s.substring(4);
     }
 
-    protected Function<String, String> trimBullet()
+    protected UnaryOperator<String> trimBullet()
     {
         return s -> s.replaceFirst("^ {0,3}[-+*]", "").trim();
     }

src/main/java/org/itsallcode/openfasttrace/report/view/html/MarkdownLineTransition.java

@@ -23,6 +23,7 @@
  */
 
 import java.util.function.Function;
+import java.util.function.UnaryOperator;
 import java.util.regex.Pattern;
 
 /**
@@ -56,7 +57,7 @@ class MarkdownLineTransition
      */
     public MarkdownLineTransition(final MarkdownLineState from, final MarkdownLineState to,
             final String pattern, final String prefix, final String postfix,
-            final Function<String, String> conversion)
+            final UnaryOperator<String> conversion)
     {
         super();
         this.from = from;

src/test/java/org/itsallcode/openfasttrace/testutil/AbstractFileBasedTest.java

@@ -32,6 +32,8 @@
 /**
  * This class is the base class for integration tests that require input files.
  */
+// This is a base class for tests and has no tests by intention.
+@SuppressWarnings("squid:S2187")
 public class AbstractFileBasedTest
 {
     protected void writeTextFile(final File file, final String content) throws IOException