Skip to content

Conversation

@jmbothe
Copy link
Contributor

@jmbothe jmbothe commented Aug 8, 2017

First chunk of editing work. Let me know if the size of this pull request is too much, too little or just right. I will probably submit the second half of Part 1 section 2 on Thursday or Friday.

Cheers!

@shintaroid
Copy link
Contributor

Good job!

Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, just one question here.

I found https://ell.stackexchange.com/a/5818 about the "capitalization after dash" and it says "do not capitalize".

| `string` | The string is read "as is", whitespaces from both sides are ignored. An empty string becomes `0`. An error gives `NaN`. |

**`ToBoolean`** -- occurs in logical operations, or can be performed with `Boolean(value)`.
**`ToBoolean`** -- Occurs in logical operations, or can be performed with `Boolean(value)`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Occurs is capitalized?

Copy link
Contributor Author

@jmbothe jmbothe Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @iliakan. Thanks for your comment. I interpreted this section sort of like a series of dictionary entries: ToString, ToBoolean, etc. They are not technically sentences -- the clause that follows "ToBoolean" lacks a subject -- but more like entry word/definition pairs. Thus, in this scenario the dash isn't interrupting a sentence, but rather separating a dictionary entry word from its definition. The definition begins with "Occurs", so it is capitalized.

But you are correct: if a dash interrupts a sentence, the word following the dash should not be capitalized. But that is not how I interpreted this section.

link to dictionary entry diagram

@iliakan iliakan merged commit e3b35f8 into javascript-tutorial:master Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants