Testcases/function object 5#1956
Merged
iliakan merged 4 commits intojavascript-tutorial:masterfrom Jun 16, 2020
Merged
Conversation
…ct/5-sum-many-brackets I used the solution and examples already in the article. I chose to make the test cases use Array.reduce() to compute the sum, instead of hard-coding the answer myself. Not sure how good of practice that is.
…vascript.info into testcases/function-object-5
Member
|
Can you make tests simpler please? Maybe split into functions instead of |
Contributor
Author
|
Sure! I'll try to get that done this evening. |
Contributor
Author
|
I've committed the changes to the branch and pushed it to my github account's version of the branch. Let me know if there's anything else I need to do. I'm done most of my school work on a single branch, so I'm still getting used to this whole pull request thing. |
Member
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.