Skip to content

Conversation

@behnammodi
Copy link

  • added a sample for limit
  • fix some output

@iliakan iliakan closed this in 6418344 Dec 31, 2020
@behnammodi
Copy link
Author

@iliakan Why? it's not polite, close PR without explanation.

@iliakan
Copy link
Member

iliakan commented Dec 31, 2020

First, thanks for the PR.

This section is about regular expressions. So more details about str.split seems extraneous.

Usually when I ask people to fix their PRs, they don't do that.
That's why I took the first change (array quotes) and applied it in the commit 6418344.

Sorry for any offence, and thanks for the contribution!

@behnammodi
Copy link
Author

behnammodi commented Dec 31, 2020

Thanks for the response, but I think we can add a refer-link for str.split

@iliakan
Copy link
Member

iliakan commented Dec 31, 2020

We could, but this method is so obvious...

@behnammodi
Copy link
Author

@iliakan Ok man 😀 , you're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants