Skip to content

Conversation

@joaquinelio
Copy link
Member

@joaquinelio joaquinelio commented Apr 3, 2021

line 111
"no way to let a cookie be accessible from another 2nd-level domain"
you mean
"no way to let a cookie be accessible from another domain" ??

if so, I would also rewrite the "domain" topic something like this.

Moved the most important lines to the top "other.com never access to..."
once stated that, no need to refer to "other site" anymore
and can focus on subdomain tricky part

@iliakan
Copy link
Member

iliakan commented Apr 17, 2021

Is it really better ?

@joaquinelio
Copy link
Member Author

I think so. git shows more diff than actually are, though.

step by step, you may agree with some:

  1. line 111 is wrong:
    There's no way to let a cookie be accessible from another 2nd-level domain, so other.com will never receive a cookie set at site.com.
    to
    There's no way to let a cookie be accessible from another XXXXXXX domain, so other.com will never receive a cookie set at site.com.

  2. moved that line (and related line 113) to the top (makes sense)

  3. then we can simplify former line 101
    ...But what's more tricky, we also won't get the cookie at a subdomain forum.site.com!
    to
    ...What's tricky, we won't get the cookie at a subdomain forum.site.com!

@joaquinelio
Copy link
Member Author

hey, why is this hanging.
No big deal.

The part that troubled me

111 **There's no way to let a cookie be accessible from another 2nd-level domain, so

I just deleted "2nd-level", if I'm wrong I can close it.

@iliakan
Copy link
Member

iliakan commented Dec 24, 2021

Well, the thing is: a cookie set by a.site.com can be accessible by b.site.com -- a different 3rd-level domain.

@iliakan
Copy link
Member

iliakan commented Dec 24, 2021

Thanks, let's merge this one! ;)

@iliakan iliakan merged commit 0cd40ae into javascript-tutorial:master Dec 24, 2021
@joaquinelio
Copy link
Member Author

joaquinelio commented Dec 24, 2021

Right!
Feeling fool -again-

1, I didnt realize "com" is 1st level domain. Maybe others have same mistake when reading the first time?
2, PR is a minor change now. I prefer: What it does, what it cant do, THEN the tricky part.

oops
merged while writing this comment
nice, thanks

@joaquinelio joaquinelio deleted the patch-10 branch December 24, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants