Skip to content

Conversation

@apoorvachikara
Copy link
Contributor

  • updated incorrect spellings
  • Updated the grammar-related errors
  • Updated punctuations

- updated incorrect spellings
- Updated the grammar-related errors
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2022

CLA assistant check
All committers have signed the CLA.

@joaquinelio
Copy link
Member

I prefer "labeled" but I'm not native English speaker.

-123 Should it be quotation marks intead of quotes? I dont like "quote" as "citation"

-328 sound broken now. original is ok, it does mean a variable. (containing the name...)

@apoorvachikara
Copy link
Contributor Author

  • I prefer "labeled" but I'm not a native English speaker
    That is fine It won't change the meaning of the statement. I can revert it.
  • 123 Should it be quotation marks instead of quotes? I don't like "quote" as "citation"
    Yes, it could be more descriptive if we use "quotation marks" instead of just quotes or quote
  • 328 sound broken now. original is ok, it does mean a variable. (containing the name...)
    The better way- If we omit values inside the quotes, it should contain the actual name to be tested. For instance:

If you are fine with the above changes, I can make these changes and request PR.

@joaquinelio
Copy link
Member

I didn't put this as review changes because my Eng is not good enough
I'm still learning:
The main meaning of "quotes" is "cite", but.
Here in the repo, "quotes" always refers to "quotation marks", the (noun) 2nd entry in the dictionary.
A string in JavaScript must be surrounded by quotes.

so, -328
I prefer the original (or simpler).
It does not "omit the value inside" but the marks:
test("name") --> test( name )

If we omit quotes, that means a variable containing the actual name to be tested.

@iliakan iliakan merged commit 1d22a35 into javascript-tutorial:master Apr 14, 2022
@iliakan
Copy link
Member

iliakan commented Apr 14, 2022

Merged, with "labeled" and "quotes" left "as is".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants