a tiny correction#557
Merged
iliakan merged 1 commit intojavascript-tutorial:masterfrom Oct 20, 2018
dagolinuxoid:patch-2
Merged
a tiny correction#557iliakan merged 1 commit intojavascript-tutorial:masterfrom dagolinuxoid:patch-2
iliakan merged 1 commit intojavascript-tutorial:masterfrom
dagolinuxoid:patch-2
Conversation
I guess 'find return' looks a bit awkward, maybe you wanted to write 'find and return' but dropped 'and'. Just 'return' seems fine. PS. I don't believe that I didn't solve the simple task yet. Few years ago I was able to handle much more complex stuff ... feelsWierdAndBadMan.
Member
|
Don't get upset, the task only looks easy =) |
Contributor
|
Hey, super minor, but I was just curious about the branch naming - I notice a bunch of people are using branch name I'm wondering is this some sort of standard pattern that I haven't heard about? It looks almost like an automated workflow how people are using this similar pattern. |
Contributor
Author
|
@tendermario you can give whatever name you want to your branch explicitly, but if you're lazy you will get something less descriptive like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess 'find return' looks a bit awkward, maybe you wanted to write 'find and return' but dropped 'and' or something like this. Just 'return' seems fine.
PS. I don't believe that I didn't solve the simple task yet. Few years ago I was able to handle much more complex stuff ... feelsWierdAndBadMan.