Skip to content

Grammatical changes#75

Merged
iliakan merged 16 commits intojavascript-tutorial:masterfrom
hadrysmateusz:master
Jul 10, 2017
Merged

Grammatical changes#75
iliakan merged 16 commits intojavascript-tutorial:masterfrom
hadrysmateusz:master

Conversation

@hadrysmateusz
Copy link
Contributor

No description provided.

@iliakan
Copy link
Member

iliakan commented Jul 8, 2017

Thanks!

Are you a native speaker?
What's wrong with the "The personal preference of the author" ?

@hadrysmateusz
Copy link
Contributor Author

Hi, no I'm not a native speaker but I've been learning and using English for quite a long time. I base my edits not only on my experience, but I double-check most of them with various dictionaries and on the internet. When it comes to your second question, it's a mistake on my part. It should be either "The personal preference of the author..."(Original) or "My personal preference as the author..."(What I was going for), but both of them are correct and upon giving it some thought, I think the original works better in context. I'm also new to GitHub so sorry for my messy commits and pull requests, still trying to get the hang of it ;)


```compare
+ Full integration with HTML/CSS.
+ Simple things done simply.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's technically correct, but it feels off when to compared to the other points on this list.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change.


Examples of such languages:

- [CoffeeScript](http://coffeescript.org/) is a "syntax sugar" for JavaScript, it introduces shorter syntax, allowing to write more precise and clear code. Usually Ruby guys like it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really wrong to omit the person here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read this sentence to myself a few times and I think it flows much better this way. It's just a gut feeling though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gendered language here (i.e. "guys") seems really clunky and old fashioned. This could be changed to "Ruby devs", "Rubyists" etc. I'm also noticing many places in the tutorial where, for example, the user is referred to as "he".

Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes, thanks, except that "simply things done simply" correction.

I saw such phrase in many places.


```compare
+ Full integration with HTML/CSS.
+ Simple things done simply.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change.

@iliakan iliakan merged commit d45de36 into javascript-tutorial:master Jul 10, 2017
@iliakan
Copy link
Member

iliakan commented Jul 10, 2017

Great fixes, thanks!

athena0304 pushed a commit to athena0304/javascript-tutorial-en that referenced this pull request Jun 4, 2018
* finish 1/02/10-ifelse

* modify accroding to first proofreader

* modify by second proofreader

* Update task.md

* Update solution.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants