Skip to content

Sync#218

Merged
pasor1 merged 28 commits intojavascript-tutorial:masterfrom
pasor1:sync
Feb 15, 2021
Merged

Sync#218
pasor1 merged 28 commits intojavascript-tutorial:masterfrom
pasor1:sync

Conversation

@pasor1
Copy link
Member

@pasor1 pasor1 commented Feb 15, 2021

No description provided.

lijunkang12 and others added 28 commits January 23, 2021 16:42
To be coherent with the solution and the picture below.
fix word "when" to "than".
remove unnecessary 'in'
 - comments are in pairs. The first of the pair talks about what
   happened "caching" and the second pair talks about what was
   alerted "the same". This is confusing.
 - changed comment so both lines tell the reader what happened
   and what result was returned.
A minor addition. (...where such thing doesn't happen. --> where such a thing doesn't happen.)
I think argN represents count of arbitrary parameters. But this syntax looks like "rest syntax". It could be more understandable to change it like this.
…rer-comments

Clearer CachingDecorator comments
Add missing semicolon in Arrow Functions (1-6-12)
Improve modyfying document task one sentence grammar
there are four logical operators in JS
fix typo: missing semicolon after let ladder = { }
Fix typo in "liseners" on line 21
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 13 committers have signed the CLA.

✅ iliakan
✅ pasor1
❌ lijunkang12
❌ fibretothepremises
❌ helloimjordan
❌ aliaghdam
❌ pawel-123
❌ seamissu
❌ lumosmind
❌ f6p
❌ MuhammedZakir
❌ notapatch
❌ asamant
You have signed the CLA already but the status is still pending? Let us recheck it.

@pasor1 pasor1 merged commit 355b255 into javascript-tutorial:master Feb 15, 2021
@pasor1 pasor1 deleted the sync branch February 15, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments