[속성과 프로퍼티] 과제 번역#518
Merged
Violet-Bora-Lee merged 1 commit intojavascript-tutorial:masterfrom Apr 10, 2020
JuYeong0413:dom-attributes-and-properties
Merged
[속성과 프로퍼티] 과제 번역#518Violet-Bora-Lee merged 1 commit intojavascript-tutorial:masterfrom JuYeong0413:dom-attributes-and-properties
Violet-Bora-Lee merged 1 commit intojavascript-tutorial:masterfrom
JuYeong0413:dom-attributes-and-properties
Conversation
JuYeong0413
commented
Mar 31, 2020
| 참고: HTML의 값이 필요하기 때문에 `link.href`가 아니라 `link.getAttribute('href')`를 사용합니다. | ||
|
|
||
| ...Another, simpler way would be to add the checks to CSS selector: | ||
| 더 간단한 방법은 CSS 선택자에서 확인하는 것입니다. |
Contributor
Author
There was a problem hiding this comment.
add the checks to 부분을 번역을 어떻게 하면 좋을지 고민을 하다 querySelectorAll의 선택자에서 걸러내는 방식이어서 확인한다고 했는데요, 더 좋은 표현이 있으면 의견 부탁드리겠습니다. 🙂
Member
There was a problem hiding this comment.
check는 여기서 명사로 쓰이고 있네요. 사전을 찾아보니, '무언가를 확인하기 위한 행동, 기준'이라는 뜻을 가지고 있고 문제에서 '조건'이라는 표현을 써서 이를 참고해 번역해보았습니다.
https://dictionary.cambridge.org/dictionary/english-korean/check
Suggested change
| 더 간단한 방법은 CSS 선택자에서 확인하는 것입니다. | |
| 더 간단한 방법은 CSS 선택자에 조건을 명시해 주는것입니다. |
| // look for all links that have :// in href | ||
| // but href doesn't start with http://internal.com | ||
| // href에 :// 가 포함된 모든 링크를 찾습니다. | ||
| // 하지만 href는 http://internal.com으로 시작하지 않아야 합니다. |
Member
There was a problem hiding this comment.
Suggested change
| // 하지만 href는 http://internal.com으로 시작하지 않아야 합니다. | |
| // 그 중 http://internal.com으로 시작하지 않는 링크를 찾습니다. |
접속사는 때에따라 생략해도 좋은것 같습니다.
Violet-Bora-Lee
requested changes
Apr 9, 2020
Member
Violet-Bora-Lee
left a comment
Violet-Bora-Lee
left a comment
There was a problem hiding this comment.
코멘트 달아주신것에 댓글로 의견 첨부해보았습니다 :)
|
Please make the requested changes. After it, add a comment "/done". |
Contributor
Author
|
/done |
Member
|
머지 진행하겠습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request 체크리스트
TODO