[기초 문법 요약] - 오번역 수정 #709#710
Merged
Violet-Bora-Lee merged 1 commit intojavascript-tutorial:masterfrom Sep 10, 2020
GreatLaboratory:fix/#709/coding-convention
Merged
[기초 문법 요약] - 오번역 수정 #709#710Violet-Bora-Lee merged 1 commit intojavascript-tutorial:masterfrom GreatLaboratory:fix/#709/coding-convention
Violet-Bora-Lee merged 1 commit intojavascript-tutorial:masterfrom
GreatLaboratory:fix/#709/coding-convention
Conversation
| ``` | ||
|
|
||
| 코딩 컨벤션과 같은 코드 스타일 지침서 대부분은 문의 끝에 세미콜론을 붙이는 걸 강제합니다. | ||
| 코딩 컨벤션과 같은 코드 스타일 지침서 대부분은 문장의 끝에 세미콜론을 붙이는 것에 대해 동의합니다. |
Member
There was a problem hiding this comment.
Contributor
Author
|
@Violet-Bora-Lee 남겨주신 리뷰내용을 참고하여 수정 완료했습니다. 수정 이후 커밋은 rebase를 이용하여 하나로 합쳐놓았습니다. 감사합니다. |
Member
|
코딩 컨벤션과 같은 코드 스타일 지침서 대부분은 문장의 끝에 세미콜론을 붙이는 것에 대해 동의합니다. 코드 스타일 지침서는 ~~~에 동의합니다. 이 문장이 어색한데.. 저만그럴까요.. |
Contributor
Author
|
@Violet-Bora-Lee 앗 그렇군요. 그럼 |
Member
|
좋네요 ㅎㅎ 이걸로 가시죠 |
Contributor
Author
|
@Violet-Bora-Lee 넵! 해당 내용으로 수정했고 rebase로 모든 커밋 합쳐놓았습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request 체크리스트
TODO