[과제번역] Part2. 2.4 Browser default actions 과제 번역 #711 by grcenneat · Pull Request #746 · javascript-tutorial/ko.javascript.info

grcenneat · 2020-08-22T18:28:43Z

Pull Request 체크리스트

TODO

번역 규칙을 확인하셨나요?
- 줄 바꿈과 단락을 '원문과 동일하게' 유지하셨나요?
- 맞춤법 검사기로 맞춤법을 확인하셨나요?
- 마크다운 문법에 사용되는 공백(스페이스), 큰따옴표("), 작은따옴표('), 대시(-), 백틱(`) 등의 특수문자는 그대로 두셨나요?
로컬 서버 세팅 후 최종 결과물을 확인해 보셨나요?
PR 하나엔 번역문 하나만 넣으셨나요?
의미 있는 커밋 메시지를 작성하셨나요?
- 예시
  - [프락시] 번역
  - [프락시] 과제 번역
  - [if문과 조건부 연산자 '?'] 리뷰
  - [주석] 2차 리뷰
  - [Date 객체와 날짜] 번역

Violet-Bora-Lee

리뷰 마쳤습니다.
큰 수정사항은 없는것 같습니다.

코멘트 보시고 확인 부탁드릴게요.

2-ui/2-events/04-default-browser-action/1-why-return-false-fails/task.md

2-ui/2-events/04-default-browser-action/2-catch-link-navigation/task.md

2-ui/2-events/04-default-browser-action/3-image-gallery/solution.md

2-ui/2-events/04-default-browser-action/3-image-gallery/task.md

javascript-translate-bot · 2020-08-25T12:33:23Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

grcenneat · 2020-08-31T16:32:27Z

/done

2-ui/2-events/04-default-browser-action/3-image-gallery/solution.md

Violet-Bora-Lee

리뷰 남겨보았습니다.

2-ui/2-events/04-default-browser-action/3-image-gallery/solution.md

2-ui/2-events/04-default-browser-action/1-why-return-false-fails/task.md

2-ui/2-events/04-default-browser-action/1-why-return-false-fails/solution.md

2-ui/2-events/04-default-browser-action/2-catch-link-navigation/task.md

2-ui/2-events/04-default-browser-action/3-image-gallery/solution.md

javascript-translate-bot · 2020-09-03T13:46:15Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

grcenneat · 2020-09-08T04:53:43Z

/done

2-ui/2-events/04-default-browser-action/2-catch-link-navigation/solution.md

javascript-translate-bot · 2020-09-10T11:54:06Z

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

grcenneat · 2020-09-11T18:00:58Z

/done

Violet-Bora-Lee · 2020-09-12T02:03:51Z

커밋 하나로 합쳐주시면 머지 진행하겠습니다.
고생많으셨습니다!

grcenneat · 2020-09-12T02:15:03Z

/done 커밋 합치기 완료했습니다! 감사합니다.

Violet-Bora-Lee · 2020-09-12T03:55:23Z

커밋 메시지 수정부탁드릴게요.
메시지만 보고 별도의 작업 없이 이 커밋에서 어떤 작업을 했는지 알수있도록 해주세요.

grcenneat · 2020-09-12T05:22:29Z

/done 커밋 메시지 한줄로 수정했습니다 !

Violet-Bora-Lee · 2020-09-12T06:07:16Z

translate/2.2.4 task and solution <-- 이 커밋메시지를 보면 2.2.4가 무엇인지 찾아보아야합니다. 어떤 부분을 작업했는지 한눈에 볼수있게 해주세요. 다른 커밋 메시지들을 참고해주세요.

grcenneat · 2020-09-12T10:48:11Z

/done 아하, 제가 잘못이해했었네요 ㅠㅠ 수정완료했습니다.

Violet-Bora-Lee · 2020-09-13T11:29:31Z

기여 감사합니다.
머지 진행할게요 👍

javascript-translate-bot added the review needed label Aug 22, 2020

grcenneat force-pushed the translate/2.2.4task branch from c8dbdc9 to 9839a5c Compare August 22, 2020 20:30

grcenneat mentioned this pull request Aug 22, 2020

[과제번역] Part3. 3.5 Fetch: Cross-Origin Requests 번역 #735 #736

Closed

7 tasks

Violet-Bora-Lee requested changes Aug 25, 2020

View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Aug 25, 2020

grcenneat mentioned this pull request Aug 31, 2020

[오번역수정] 이벤트 위임에서 '컨테이너'에 대한 번역 개선 #820

Open

javascript-translate-bot added review needed and removed changes requested labels Aug 31, 2020

grcenneat commented Aug 31, 2020

View reviewed changes

2-ui/2-events/04-default-browser-action/3-image-gallery/solution.md Outdated Show resolved Hide resolved

Violet-Bora-Lee requested changes Sep 3, 2020

View reviewed changes

javascript-translate-bot added changes requested and removed review needed labels Sep 3, 2020

grcenneat force-pushed the translate/2.2.4task branch from bceb789 to 55a6553 Compare September 8, 2020 04:50

javascript-translate-bot added review needed and removed changes requested labels Sep 8, 2020

Violet-Bora-Lee requested changes Sep 10, 2020

View reviewed changes

2-ui/2-events/04-default-browser-action/2-catch-link-navigation/solution.md Outdated Show resolved Hide resolved

2-ui/2-events/04-default-browser-action/2-catch-link-navigation/solution.md Outdated Show resolved Hide resolved

javascript-translate-bot added changes requested and removed review needed labels Sep 10, 2020

grcenneat force-pushed the translate/2.2.4task branch from 55a6553 to 0797642 Compare September 11, 2020 17:59

javascript-translate-bot added review needed and removed changes requested labels Sep 11, 2020

Violet-Bora-Lee removed the review needed label Sep 12, 2020

Violet-Bora-Lee added the changes requested label Sep 12, 2020

grcenneat force-pushed the translate/2.2.4task branch from 0797642 to 4e9034c Compare September 12, 2020 02:14

javascript-translate-bot added review needed and removed changes requested labels Sep 12, 2020

Violet-Bora-Lee added changes requested and removed review needed labels Sep 12, 2020

grcenneat force-pushed the translate/2.2.4task branch from 4e9034c to f37c0df Compare September 12, 2020 05:20

javascript-translate-bot added review needed and removed changes requested labels Sep 12, 2020

Violet-Bora-Lee added changes requested and removed review needed labels Sep 12, 2020

[과제번역] Part2 2.4 브라우저 기본동작 과제및해답 번역

6b877c1

grcenneat force-pushed the translate/2.2.4task branch from f37c0df to 6b877c1 Compare September 12, 2020 10:45

javascript-translate-bot added review needed and removed changes requested labels Sep 12, 2020

Violet-Bora-Lee merged commit a092ce1 into javascript-tutorial:master Sep 13, 2020

grcenneat deleted the translate/2.2.4task branch September 13, 2020 11:45

Conversation

grcenneat commented Aug 22, 2020

Pull Request 체크리스트

TODO

Uh oh!

Violet-Bora-Lee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Aug 25, 2020

Uh oh!

grcenneat commented Aug 31, 2020

Uh oh!

Uh oh!

Violet-Bora-Lee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 3, 2020

Uh oh!

grcenneat commented Sep 8, 2020

Uh oh!

Uh oh!

Uh oh!

javascript-translate-bot commented Sep 10, 2020

Uh oh!

grcenneat commented Sep 11, 2020

Uh oh!

Violet-Bora-Lee commented Sep 12, 2020

Uh oh!

grcenneat commented Sep 12, 2020

Uh oh!

Violet-Bora-Lee commented Sep 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grcenneat commented Sep 12, 2020

Uh oh!

Violet-Bora-Lee commented Sep 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grcenneat commented Sep 12, 2020

Uh oh!

Violet-Bora-Lee commented Sep 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Violet-Bora-Lee commented Sep 12, 2020 •

edited

Loading

Violet-Bora-Lee commented Sep 12, 2020 •

edited

Loading