Skip to content

[웹소켓] 번역, line28(#883)#904

Merged
Violet-Bora-Lee merged 1 commit intojavascript-tutorial:masterfrom
kangsw1025:sub
Oct 16, 2020
Merged

[웹소켓] 번역, line28(#883)#904
Violet-Bora-Lee merged 1 commit intojavascript-tutorial:masterfrom
kangsw1025:sub

Conversation

@kangsw1025
Copy link
Copy Markdown
Contributor

@kangsw1025 kangsw1025 commented Oct 15, 2020

Pull Request 체크리스트

TODO

  • 번역 규칙을 확인하셨나요?
    • 줄 바꿈과 단락을 '원문과 동일하게' 유지하셨나요?
    • 맞춤법 검사기로 맞춤법을 확인하셨나요?
    • 마크다운 문법에 사용되는 공백(스페이스), 큰따옴표("), 작은따옴표('), 대시(-), 백틱(`) 등의 특수문자는 그대로 두셨나요?
  • 로컬 서버 세팅 후 최종 결과물을 확인해 보셨나요?
  • PR 하나엔 번역문 하나만 넣으셨나요?
  • 의미 있는 커밋 메시지를 작성하셨나요?
    • 예시
      • [프락시] 번역
      • [프락시] 과제 번역
      • [if문과 조건부 연산자 '?'] 리뷰
      • [주석] 2차 리뷰
      • [Date 객체와 날짜] 번역

@javascript-translate-bot javascript-translate-bot requested a review from a team October 15, 2020 07:26
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 15, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Violet-Bora-Lee
Copy link
Copy Markdown
Member

Violet-Bora-Lee commented Oct 15, 2020

충돌해결부탁드려요

@kangsw1025 kangsw1025 closed this Oct 16, 2020
@kangsw1025 kangsw1025 reopened this Oct 16, 2020
@Violet-Bora-Lee
Copy link
Copy Markdown
Member

Violet-Bora-Lee commented Oct 16, 2020

LGTM!
기여해주셔서 감사합니다.

@Violet-Bora-Lee Violet-Bora-Lee merged commit 9f85744 into javascript-tutorial:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kangsw1025 @CLAassistant @Violet-Bora-Lee @javascript-translate-bot