Skip to content

Sync with upstream @ 47d18659#37

Closed
javascript-translate-bot wants to merge 760 commits intomasterfrom
sync-47d18659
Closed

Sync with upstream @ 47d18659#37
javascript-translate-bot wants to merge 760 commits intomasterfrom
sync-47d18659

Conversation

@javascript-translate-bot

This PR was automatically generated to merge changes from en.javascript.info at 47d1865

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

Click to open a list of 184 files

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

This PR will be closed and replaced with a new one in a few days.

hrodward and others added 30 commits October 23, 2019 15:23
Grammar suggestions
Grammar suggestions
Changed spelling of "neighbor" from British ("neighbour") to American.

I think that's how you want it. Otherwise some other stuff has to be switched to British.
"Although, " to "However,".
Spelling things out a bit more for insertAdjacentHTML
Further tweaks in the insertAdjacent... neighborhood of Summary.
Update article.md
Grammar suggestions
Update article.md
Update article.md
Update article.md
Update article.md
Grammar suggestions
Update article.md
Grammar suggestions
Grammar suggestions
Wouldn't this solution be more flexible?
iliakan and others added 26 commits November 30, 2019 09:03
Update 'Window sizes and scrolling' article.md
Consistent HTML for the task source and solution
consistent CSS for the task and the solution
Fix small grammar mistake in closure makeArmy task
BigInt Type added in primitive types
Grammar and phrasing changes to first paragraph. Not 100% sure didn't change meaning so am leaving it for review.
Grammar and phrasing changes to first paragraph. Wasn't 100% sure didn't change meaning and was going to leave it for review, but it seems I already committed it somehow when I was trying to make revisions, so hope it's right.
consistent error output comments
@claassistantio
Copy link

claassistantio commented Dec 2, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 7 committers have signed the CLA.

✅ iliakan
❌ lex111
❌ masterashu
❌ paroche
❌ dashaezhova
❌ koala-lava
❌ spaceinvadev
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.