Skip to content

Conversation

@keslo
Copy link
Contributor

@keslo keslo commented May 31, 2019

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label May 31, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team May 31, 2019 07:09
@xcurveballx
Copy link
Member

Привет! Похоже, что переведена только 1/4 статьи примерно. Если это еще в процессе, то надо ставить метку WIP (work in progress) или не создавать PR. Сейчас висит PR как будто всё готово.

@keslo
Copy link
Contributor Author

keslo commented Jun 10, 2019

@xcurveballx основная статья готова к ревью

@xcurveballx
Copy link
Member

хорошо, там еще несколько задачек. Тогда как их переведешь - я сниму лейбл WIP.

@keslo
Copy link
Contributor Author

keslo commented Jun 18, 2019

хорошо, там еще несколько задачек. Тогда как их переведешь - я сниму лейбл WIP.

@xcurveballx готово к ревью. Задачки перевел.

@keslo
Copy link
Contributor Author

keslo commented Jun 19, 2019

/done

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jun 20, 2019
@keslo
Copy link
Contributor Author

keslo commented Jun 21, 2019

@xcurveballx благодарю за ревью

@javascript-translate-bot javascript-translate-bot removed the review needed Review needed, please approve or request changes label Jun 24, 2019
@javascript-translate-bot javascript-translate-bot added the needs +1 One more review needed label Jun 24, 2019
@xcurveballx xcurveballx added the review needed Review needed, please approve or request changes label Jun 25, 2019
Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо, хороший перевод! Пожалуйста, внеси исправления.

@javascript-translate-bot javascript-translate-bot removed the review needed Review needed, please approve or request changes label Jun 25, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Jun 25, 2019
@keslo
Copy link
Contributor Author

keslo commented Jun 26, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jun 26, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team June 26, 2019 14:20
@javascript-translate-bot javascript-translate-bot removed the review needed Review needed, please approve or request changes label Jun 26, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Jun 26, 2019
@keslo
Copy link
Contributor Author

keslo commented Jun 27, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jun 27, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team June 27, 2019 08:31
@iliakan
Copy link
Member

iliakan commented Jun 27, 2019

🚀

@javascript-translate-bot javascript-translate-bot merged commit 196b379 into javascript-tutorial:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 One more review needed review needed Review needed, please approve or request changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants