Skip to content

Shadow dom style#315

Merged
javascript-translate-bot merged 16 commits intojavascript-tutorial:masterfrom
alfill:shadow-dom-style
Jul 23, 2019
Merged

Shadow dom style#315
javascript-translate-bot merged 16 commits intojavascript-tutorial:masterfrom
alfill:shadow-dom-style

Conversation

@alfill
Copy link
Contributor

@alfill alfill commented Jul 21, 2019

Извиняюсь за задержку. Собственно перевод

alfill added 4 commits May 1, 2019 02:50
Добавил неявное importance - ни код, ни комментарий, что не переводится нужно только догадываться
+ пара ресурсов переводчику
@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jul 21, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team July 21, 2019 07:17
@alfill alfill marked this pull request as ready for review July 21, 2019 07:17
Copy link
Member

@xcurveballx xcurveballx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я внёс некоторые правки на основе перевода прошлых статей, но на самом деле я не особо разбираюсь в этой теме, так что не могу как-то качественно улучшить перевод.

@javascript-translate-bot javascript-translate-bot removed the review needed Review needed, please approve or request changes label Jul 21, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added the changes requested Waiting for changes and /done from PR author label Jul 21, 2019
alfill added 2 commits July 21, 2019 15:15
…fo into shadow-dom

Merge branch 'shadow-dom-style' of github.com:alfill/ru.javascript.info into shadow-dom
@alfill
Copy link
Contributor Author

alfill commented Jul 21, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jul 21, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team July 21, 2019 13:28
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jul 21, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added needs +1 One more review needed changes requested Waiting for changes and /done from PR author and removed changes requested Waiting for changes and /done from PR author labels Jul 21, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@iliakan iliakan added the partially reviewed Last review only took a part of the article. Full re-review (not just changes since last) required label Jul 21, 2019
@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jul 22, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team July 22, 2019 07:47
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jul 22, 2019
@alfill
Copy link
Contributor Author

alfill commented Jul 22, 2019

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jul 22, 2019
@javascript-translate-bot javascript-translate-bot requested a review from a team July 22, 2019 14:39
Copy link
Member

@iliakan iliakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо! Плиз .gitignore убери файл?

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jul 22, 2019
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@iliakan iliakan removed the partially reviewed Last review only took a part of the article. Full re-review (not just changes since last) required label Jul 22, 2019
@alfill
Copy link
Contributor Author

alfill commented Jul 23, 2019

@iliakan, откатил случайное удаление у меня gitignore, чтобы больше здесь не мешался

@xcurveballx xcurveballx added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jul 23, 2019
@iliakan
Copy link
Member

iliakan commented Jul 23, 2019

🚀

@javascript-translate-bot javascript-translate-bot merged commit b32b9df into javascript-tutorial:master Jul 23, 2019
@alfill alfill deleted the shadow-dom-style branch July 23, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs +1 One more review needed review needed Review needed, please approve or request changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants