Sync with upstream @ 3a0b3f4e #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fis typo in 2.5.2 (Scripts: async, defer)
fix nested markdown
Various minor punctuation and phrasing changes.
Update article.md
(even more minor)
More little tweaks. That should do for now.
Fix my typos in 1.5.5
Clarify a bit ambiguous wording in 1.5.7
Include missing fileServer
Rephrase sentence.
Fix typo in 2.3.3 (Moving the mouse...)
Symmetrize Map and Set summaries
Fix possible typo in 1.5.7 task
Clarify some things in 1.5.12
FIX: some typo error
Minor grammar alteration.
Rephrased for better clarity.
Fix typo in 2.2.5 (Dispatching custom events)
Fix typo in 2.3.1 (Mouse events)
Buffer purpose. And missing "s".
parameters are also local variables
It is should be made know that `new.target` is `undefined` for regular function calls than say it is empty.
new.target is undefined not empty
For completeness of the test cases we could add tests for the read method. So every method can have individual test cases.
fix spelling of `further`
to ensure completeness, every method should have their own individual test case.
there is nothing to see when code is run. So run button for code can create some confusion.
no need to "js run"
individual test case for methods
Update article.md
each unit parts must be tested
"exception" vs "new feature" ?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at 3a0b3f4
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
Click to open a list of 191 files
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterPlease ignore changes in README.md (git checkout --ours README.md && git commit -m ignore README.md).
This PR will be closed and replaced with a new one in a few days.