Skip to content

Delegation A3: deliver the minted invite to the requesting peer (delivery ONLY) - #2323

Closed
jaylfc wants to merge 1 commit into
devfrom
exec/tsk-l6gqvw
Closed

Delegation A3: deliver the minted invite to the requesting peer (delivery ONLY)#2323
jaylfc wants to merge 1 commit into
devfrom
exec/tsk-l6gqvw

Conversation

@jaylfc

@jaylfc jaylfc commented Aug 9, 2026

Copy link
Copy Markdown
Owner

CARD TITLE (intent, not commit subject): Delegation A3: deliver the minted invite to the requesting peer (delivery ONLY)

Autonomous build of board card tsk-l6gqvw.

REVIEW WARNING (automated): this card's text asks for tests, but the diff changes no test file. Either the acceptance criteria are unmet or the card needs correcting. Do not merge without resolving this.

registry: per-identity token rotation via token_min_iat (fixes #2205)

Files:
changelog.d/2290-changelog-fragments.md | 6 ++++++
changelog.d/2298-tasks-to-routines.md | 5 +++++
changelog.d/2313-consent-defer-active-handle.md | 7 +++++++
changelog.d/2314-cryptography-50.md | 5 +++++
desktop/package.json | 2 +-
pyproject.toml | 2 +-
tinyagentos/init.py | 2 +-
9 files changed, 29 insertions(+), 30 deletions(-)

registry: per-identity token rotation via token_min_iat (fixes #2205)
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jaylfc, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f2c443b7-ce31-48bf-ad87-23d366012dd8

📥 Commits

Reviewing files that changed from the base of the PR and between fc1de1d and c614bba.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock, !**/uv.lock
📒 Files selected for processing (5)
  • tests/test_agent_registry_store.py
  • tests/test_token_rotation.py
  • tinyagentos/agent_registry_store.py
  • tinyagentos/agent_token_auth.py
  • tinyagentos/routes/agent_registry.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gitar-bot

gitar-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@kilo-code-bot

kilo-code-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 1
WARNING 0
SUGGESTION 0
Issue Details (click to expand)

CRITICAL

File Line Issue
tinyagentos/agent_token_auth.py 202 check_agent_identity does not enforce token_min_iat, allowing superseded tokens to authenticate via identity-only paths
Files Reviewed (5 files)
  • tests/test_agent_registry_store.py - no issues
  • tests/test_token_rotation.py - no issues
  • tinyagentos/agent_registry_store.py - no issues
  • tinyagentos/agent_token_auth.py - 1 issue
  • tinyagentos/routes/agent_registry.py - no issues

Findings

CRITICAL: check_agent_identity in tinyagentos/agent_token_auth.py does not enforce the new token_min_iat rotation cutoff. The PR adds the supersession check to _verify_agent_scope, but check_agent_identity returns the canonical_id directly after the active-status check without verifying that the token's iat is still current. This function is used by routes/decisions.py and routes/agent_auth_requests.py, meaning an attacker holding a token minted before a rotation bump can still authenticate through those endpoints. The token_min_iat guard should be extracted to a shared helper and applied to both _verify_agent_scope and check_agent_identity.


Fix these issues in Kilo Cloud


Reviewed by step-3.7-flash · Input: 187.4K · Output: 42.5K · Cached: 790.9K

@jaylfc

jaylfc commented Aug 9, 2026

Copy link
Copy Markdown
Owner Author

Closing as a stale replay — this diff is PR #2208's already-merged token-rotation content wearing this card's title. Third-instance day for the class (#2324, #2322, #2323): the lane build environment is composing branches from a stale workspace still holding the #2208 branch. Dispatcher-side fix is tsk-vza6o3, now escalated; the card this PR carried is held by the lead until that lands, because a re-dispatch would replay again.

@jaylfc jaylfc closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant