Deploy taosmd to the Pi: 15 commits behind, carries the WAL/busy-timeout fix for SQLITE_BUSY under concurrent agents - #2324
Deploy taosmd to the Pi: 15 commits behind, carries the WAL/busy-timeout fix for SQLITE_BUSY under concurrent agents#2324jaylfc wants to merge 1 commit into
Conversation
registry: per-identity token rotation via token_min_iat (fixes #2205)
|
Warning Review limit reached
Next review available in: 25 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as a stale replay: this diff is PR #2208's token-rotation content (same five files, same commit subject, |
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
| if record is None: | ||
| return None | ||
| await self._db.execute( | ||
| "UPDATE agent_registry SET token_min_iat = MAX(token_min_iat, ?) WHERE canonical_id = ?", |
There was a problem hiding this comment.
WARNING: TOCTOU race condition in bump_token_min_iat — MAX(token_min_iat, ?) is not atomic with respect to the read-modify-write cycle
If two concurrent requests arrive with different timestamps, both read the current value first, then whichever UPDATE executes last wins. If Request A (ts=3000) writes first and Request B (ts=2000) writes second, the final value becomes 2000 — moving the cutoff backward and re-validating tokens that should remain superseded.
Example interleaving:
- Request A reads token_min_iat=0
- Request B reads token_min_iat=0
- Request A executes: MAX(0, 3000) → 3000
- Request B executes: MAX(0, 2000) → 2000 ← regression
Fix: add a guard to the WHERE clause so the update is a no-op when the stored value is already >= the proposed timestamp:
UPDATE agent_registry SET token_min_iat = ? WHERE canonical_id = ? AND token_min_iat < ?
This guarantees monotonic forward progress regardless of write order.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 149.6K · Output: 11.7K · Cached: 758.7K |
CARD TITLE (intent, not commit subject): Deploy taosmd to the Pi: 15 commits behind, carries the WAL/busy-timeout fix for SQLITE_BUSY under concurrent agents
Autonomous build of board card tsk-no436s.
registry: per-identity token rotation via token_min_iat (fixes #2205)
Files:
changelog.d/2290-changelog-fragments.md | 6 ++++++
changelog.d/2298-tasks-to-routines.md | 5 +++++
changelog.d/2313-consent-defer-active-handle.md | 7 +++++++
changelog.d/2314-cryptography-50.md | 5 +++++
desktop/package.json | 2 +-
pyproject.toml | 2 +-
tinyagentos/init.py | 2 +-
9 files changed, 29 insertions(+), 30 deletions(-)