Skip to content

use 'git whatchanged' instead of 'git show'#69

Closed
memory wants to merge 1 commit intojenkinsci:masterfrom
memory:master
Closed

use 'git whatchanged' instead of 'git show'#69
memory wants to merge 1 commit intojenkinsci:masterfrom
memory:master

Conversation

@memory
Copy link

@memory memory commented May 21, 2012

This forces file-by-file evaluation necessary for included/excluded
regions to be applied correctly to merge commits.

See: https://issues.jenkins-ci.org/browse/JENKINS-13580, which we
believe is resolved here.

This forces file-by-file evaluation necessary for included/excluded
regions to be applied correctly to merge commits.

See: https://issues.jenkins-ci.org/browse/JENKINS-13580, which we
believe is resolved here.
@buildhive
Copy link

Jenkins » git-plugin #11 SUCCESS
This pull request looks good
(what's this?)

@blatinville
Copy link

I've opened a pull request with included region which impacts the same part of code.

Issue is that multiple commits in one push are ignored :
#70

@kohsuke
Copy link
Member

kohsuke commented Jun 26, 2012

I'm not exactly sure what the difference is between git whatchanged but git show, but I'm merging this change toward 1.1.20.

@kohsuke kohsuke closed this Jun 26, 2012
@memory
Copy link
Author

memory commented Jun 26, 2012

Argh, you're actually going to want to revert this in favor of cormallen@61cf887 -- Harry and I figured out a few days ago that 'git show' had some showstopper bugs (see https://gist.github.com/232acf832fd7840eb44a and http://news.gmane.org/find-root.php?message_id=%3cd3e839101b031a7208e74a0b6e22d343d5a093e9.1340136145.git.trast%40student.ethz.ch%3e) and have fallen back to using 'git log'.

@memory
Copy link
Author

memory commented Jun 26, 2012

(My apologies for not immediately canceling this pull req -- things got a little hectic.)

@anatoly-spb
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants