E2: remove ICA deprecation shims (#714) - #742
Merged
Merged
Conversation
Remove every ICA shim marked removal:2.1 in DEPRECATIONS.md: - The 1.x standalone surface: `Converter`, `dqdv_cycle`, `dqdv_cycles`, `dqdv_np` (and their `_impl`/legacy-split machinery) -- deleted the whole "deprecated 1.x surface" section of cellpy/ica.py. - The legacy `dqdv(cycle=/split=/tidy=/label_direction=)` keyword routing (`_pop_legacy_dqdv_kwargs` / `_legacy_dqdv`); `dqdv` now always returns the specced long frame via `_transform_all`. - The duplicate `dq` output column: dropped `IcaCols.legacy_dqdv` and the two places (`_transform_all`, `_empty_frame`) that appended it, plus the drop in the ICA plotting-prepare. The frame is now `cycle/direction/voltage/capacity/ dqdv` (dvdq unchanged). Updated `__all__` in cellpy/ica.py and the cellpy/utils/ica.py re-export shim, trimmed the E2 rows from the `_deprecation` seed, and regenerated DEPRECATIONS.md. Tests: the entire ICA golden suite (`ICA_GOLDEN_CASES` / `test_ica_goldens.py` / the 8 `tests/data/goldens/ica_dqdv_*` oracles) existed only to pin the deprecated 1.x numbers bit-for-bit, so it was removed; `ica_golden_support.py` is trimmed to the shared `load_golden_cell`. `dev/regenerate_goldens.py` drops the ICA regen. Rewrote `test_ica.py` onto the modern specced API and fixed the `dq`-column expectations in `test_ica_api.py` / `test_ica_plot_prepare.py`. The modern `transform_half_cycle` numeric oracle in test_ica_api.py is the remaining ICA regression net; `collect_ica` (Epic B) stays green (it never required the `dq` column). Closes #714 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic E, arc E2 (#714) — remove ICA shims
Removes every ICA shim marked
removal: 2.1inDEPRECATIONS.md.Removed
Converter,dqdv_cycle,dqdv_cycles,dqdv_np(+ their_impl/ legacy-split machinery) — deleted the whole "deprecated 1.x surface" section ofcellpy/ica.py.dqdvkwargs:cycle=/split=/tidy=/label_direction=routing (_pop_legacy_dqdv_kwargs/_legacy_dqdv).dqdvnow always returns the specced long frame via_transform_all.dqcolumn: droppedIcaCols.legacy_dqdvand the three places that referenced it (_transform_all,_empty_frame, and the ICA plotting-prepare). The frame is nowcycle/direction/voltage/capacity/dqdv.Updated
__all__(ica.py + theutils/ica.pyre-export shim), trimmed the E2 rows from the_deprecationseed, regeneratedDEPRECATIONS.md.Tests
The entire ICA golden suite (
ICA_GOLDEN_CASES/test_ica_goldens.py/ the 8tests/data/goldens/ica_dqdv_*oracles) existed only to pin the deprecated 1.x numbers bit-for-bit, so it was removed;ica_golden_support.pyis trimmed to the sharedload_golden_cell(still used by the curve goldens + figure specs), anddev/regenerate_goldens.pydrops the ICA regen. Rewrotetest_ica.pyonto the modern specced API and fixed thedq-column expectations intest_ica_api.py/test_ica_plot_prepare.py.The modern
transform_half_cyclenumeric oracle intest_ica_api.pyis the remaining ICA regression net;collect_ica(Epic B) stays green — it never required thedqcolumn. Local sweep (ICA/collect/plotting, Agg backend): 230 passed.Closes #714