Skip to content

E2: remove ICA deprecation shims (#714) #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jepegit merged 1 commit into from
Jul 27, 2026
Merged

E2: remove ICA deprecation shims (#714) #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions DEPRECATIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,5 @@ uv run python -m cellpy._deprecation

| Name | Replacement | Introduced | Removal |
| --- | --- | --- | --- |
| `ica.Converter` | `cellpy.ica.transform_half_cycle with IcaOptions` | 2.0 | 2.1 |
| `ica.dqdv(cycle=...)` | `cellpy.ica.dqdv(cycles=...)` | 2.0 | 2.1 |
| `ica.dqdv(label_direction=...)` | `the direction column, which the specced frame always carries` | 2.0 | 2.1 |
| `ica.dqdv(split=... / tidy=...)` | `cellpy.ica.dqdv(direction=...) and cellpy.ica.to_wide()` | 2.0 | 2.1 |
| `ica.dqdv_cycle` | `cellpy.ica.dqdv (returns the specced long frame)` | 2.0 | 2.1 |
| `ica.dqdv_cycles` | `cellpy.ica.dqdv (returns the specced long frame)` | 2.0 | 2.1 |
| `ica.dqdv_np` | `cellpy.ica.transform_half_cycle with IcaOptions` | 2.0 | 2.1 |
| `legacy header attribute access (headers_normal / _summary / _step_table)` | `c.schema.raw / c.schema.steps / c.schema.summary` | 2.0 | 2.1 |
| `make_new_cell` | `CellpyCell.vacant` | 2.0 | 2.1 |
| `the 'dq' column of the ica output frame` | `the 'dqdv' column of the same frame` | 2.0 | 2.1 |
42 changes: 3 additions & 39 deletions cellpy/_deprecation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,45 +107,9 @@ def _seed_known_deprecations() -> None:
# cellpy.utils.easyplot was removed in 2.0 (#544); it is no longer a
# pending deprecation, so it is dropped from the registry / DEPRECATIONS.md.

# ICA redesign (#566). The 1.x entry points survive as shims over the new
# pure core and reproduce the old numbers exactly; they warn per call site.
_register(
"ica.Converter",
"cellpy.ica.transform_half_cycle with IcaOptions",
removal="2.1",
)
_register(
"ica.dqdv_cycle",
"cellpy.ica.dqdv (returns the specced long frame)",
removal="2.1",
)
_register(
"ica.dqdv_cycles",
"cellpy.ica.dqdv (returns the specced long frame)",
removal="2.1",
)
_register(
"ica.dqdv_np",
"cellpy.ica.transform_half_cycle with IcaOptions",
removal="2.1",
)
_register("ica.dqdv(cycle=...)", "cellpy.ica.dqdv(cycles=...)", removal="2.1")
_register(
"ica.dqdv(label_direction=...)",
"the direction column, which the specced frame always carries",
removal="2.1",
)
_register(
"ica.dqdv(split=... / tidy=...)",
"cellpy.ica.dqdv(direction=...) and cellpy.ica.to_wide()",
removal="2.1",
)
# The ICA output frame carries both spellings for one release.
_register(
"the 'dq' column of the ica output frame",
"the 'dqdv' column of the same frame",
removal="2.1",
)
# ICA 1.x shims (Converter, dqdv_cycle/cycles/np, dqdv split=/tidy=/cycle=/
# label_direction=, the duplicate 'dq' column) were removed in 2.1 (E2, #714)
# -- no longer registered here.

# Plotting shims (interactive=, xlim/ylim, backend="seaborn", summary_plot_legacy)
# were removed in 2.1 (E1, #713) -- no longer registered here.
Expand Down
Loading
Loading