Skip to content

remove tap command for homebrew - #149

Merged
dawidd6 merged 3 commits into
jesseduffield:masterfrom
ekremkaraca:patch-1
Aug 21, 2019
Merged

remove tap command for homebrew#149
dawidd6 merged 3 commits into
jesseduffield:masterfrom
ekremkaraca:patch-1

Conversation

@ekremkaraca

Copy link
Copy Markdown
Contributor

No longer needed, it's already in core formula

No longer needed, it's already in core formula
@codecov-io

codecov-io commented Aug 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   26.12%   26.12%           
=======================================
  Files          13       13           
  Lines        1129     1129           
=======================================
  Hits          295      295           
  Misses        821      821           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8970352...91ec431. Read the comment docs.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   26.12%   26.12%           
=======================================
  Files          13       13           
  Lines        1129     1129           
=======================================
  Hits          295      295           
  Misses        821      821           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8970352...c764c9e. Read the comment docs.

@dawidd6

dawidd6 commented Aug 10, 2019

Copy link
Copy Markdown
Collaborator

Yes, we are aware of this, but idk if it's a good idea to completely not mention the tap.
I mean it's already nicely configured and updates are almost instant, where in the core one must to manually submit a PR and wait for maintainers.

So I propose to mention that the tap exists and can be used to get updates quicker.

@jesseduffield

Copy link
Copy Markdown
Owner

I agree with @dawidd6 :)

@ekremkaraca

Copy link
Copy Markdown
Contributor Author

@dawidd6 @jesseduffield I've updated my commit after your valuable comments.

@dawidd6
dawidd6 merged commit b8d477f into jesseduffield:master Aug 21, 2019
@dawidd6

dawidd6 commented Aug 21, 2019

Copy link
Copy Markdown
Collaborator

Nice, thanks man.

@ekremkaraca
ekremkaraca deleted the patch-1 branch August 21, 2019 13:07
@ekremkaraca

Copy link
Copy Markdown
Contributor Author

@dawidd6 you're welcome:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants