fix CI - #313
Merged
Merged
Conversation
jesseduffield
force-pushed
the
fix-goreleaser
branch
from
May 9, 2022 10:23
6a2399b to
1eec32f
Compare
Owner
Author
|
Alright so I found some code that's specifically build around ensuring we can kill subprocesses thanks to #185. So this is good to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our CI fails because windows does not support syscall.Kill, nor does it support SetPgid. This PR instead replaces it with a regular process kill.
These two things were added in this commit: 892fc09
But I'm not sure if they're necessary. I want to know whether the ssh command here ever creates its own child processes.
There was some discussion on this here: 4e201bb#r757413230
I don't have an ssh setup on my own machine so it's tricky for me to test this. @cmoog can I enlist you to take another look at this?
If the PR in its current form has issues we'll need to find a way to do this which is compatible with windows.
See #273 for discussion