use sdk to obtain container logs - #336
Merged
Merged
Conversation
jesseduffield
force-pushed
the
inspect-via-sdk
branch
from
May 11, 2022 09:11
510b0f4 to
5917108
Compare
jesseduffield
force-pushed
the
inspect-via-sdk
branch
from
May 11, 2022 09:12
5917108 to
0b70171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MUCH faster!
I'm removing the
commandTemplates.containerLogskey from the config, which previously defaulted todocker logs --timestamps --follow --since=60m {{ .Container.ID }}and I'm replacing it with:So anybody who's modified the
commandTemplates.containerLogscommand may need to go and update their config to retain the same settings.If somebody is calling the logs command without going through docker, then I'll need to restore the old approach. Happy to wait and see if that's the case.