Skip to content

JITSU-125 Dedupe switcher footer: single "All Workspaces (N)" link#1422

Merged
vklimontovich merged 1 commit into
newjitsufrom
vladimir/jitsu-125-single-all-workspaces-link
Jul 23, 2026
Merged

JITSU-125 Dedupe switcher footer: single "All Workspaces (N)" link#1422
vklimontovich merged 1 commit into
newjitsufrom
vladimir/jitsu-125-single-all-workspaces-link

Conversation

@vklimontovich

Copy link
Copy Markdown
Contributor

Follow-up to #1421 (that PR merged before this commit synced into it, so this change was left behind).

The switcher dropdown showed two links to /workspaces — a "More (N)" item and "All Workspaces". This removes the duplicate "More" item and folds the count into the single "All Workspaces" link, formatted with a thousands separator and shown only when there are more workspaces than listed inline:

  • Before: More (5738) + All Workspaces
  • After: All Workspaces (5,748)

JITSU-125

jitsu-code-review[bot]
jitsu-code-review Bot previously approved these changes Jul 23, 2026

@jitsu-code-review jitsu-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the WorkspacePageLayout workspace-switcher change in this PR, including pagination/count behavior against /api/workspace?page=0&limit=10.

I did not find actionable bugs, security issues, or correctness regressions in this diff.

JITSU-125

The switcher listed two links to /workspaces ("More (N)" + "All Workspaces").
Replace both with a single "View all workspaces" action below the divider,
showing the total as a muted, comma-formatted count with a chevron. It only
appears when there are more workspaces than listed inline; a short list shows
all of them with no extra link.

@jitsu-code-review jitsu-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the workspace-switcher cleanup in WorkspacePageLayout.tsx (deduping /workspaces links and new count presentation). I found one potential user-visible regression around navigation fallback and left an inline comment with details.

</Link>
),
},
...(hasMore

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential regression question: with this hasMore guard, users no longer get any /workspaces link when they have <= 10 workspaces (or when the recent-workspaces request fails and totalCount defaults to 0). Previously All Workspaces was always available as a fallback navigation path. Was removing that fallback intentional?

@vklimontovich
vklimontovich merged commit ab9bfd1 into newjitsu Jul 23, 2026
5 checks passed
@vklimontovich
vklimontovich deleted the vladimir/jitsu-125-single-all-workspaces-link branch July 23, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant