Use goroutine for release check and fixed login in osctrl-admin#787
Merged
Use goroutine for release check and fixed login in osctrl-admin#787
osctrl-admin#787Conversation
javuto
added
✨ enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
Follow-up to #785 to correct the “suggested release” comparison messaging in osctrl-admin and make the remote release check non-blocking during service startup.
Changes:
- Fix the
CheckSuggestedReleaseconditional so “up to date” vs “newer version available” logs are emitted in the correct cases. - Run
checkLatestRelease()asynchronously via a goroutine during startup. - Simplify the initial “checking for latest release” log message.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up fix to #785 with correct logic and using a goroutine so the check is async.