Skip to content

Use goroutine for release check and fixed login in osctrl-admin #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javuto merged 2 commits into from
Mar 30, 2026
Merged

Use goroutine for release check and fixed login in osctrl-admin #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efe80e4
Use goroutine for release check and fixed login in osctrl-admin
javuto Mar 30, 2026
21d3f73
Better messaging when a release upgrade is suggested
javuto Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cmd/admin/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,17 +186,17 @@ func init() {

// Retrieve latest release information and compare
func checkLatestRelease() {
log.Info().Msg("Checking for the latest release... (timeout 10s)")
log.Info().Msg("Checking for the latest release...")
latest, err := version.RetrieveVersionData(version.VersionDataURL)
if err != nil {
log.Err(err).Msg("Error retrieving latest release information")
return
}
if version.CheckSuggestedRelease(latest.SuggestedRelease) {
log.Info().Msgf("A newer version of %s is available: %s (current: %s)", serviceName, latest.SuggestedRelease, buildVersion)
log.Info().Msgf("Release notes: %s", latest.MoreInformation)
log.Info().Msgf("%s (%s) is up to date with the suggested release (%s), latest %s", serviceName, buildVersion, latest.SuggestedRelease, latest.LatestRelease)
} else {
log.Info().Msgf("%s is up to date with the latest release (%s)", serviceName, buildVersion)
log.Info().Msgf("Please upgrade %s to at least %s. Latest version available: %s (current: %s)", serviceName, latest.SuggestedRelease, latest.LatestRelease, buildVersion)
log.Info().Msgf("Release notes: %s", latest.MoreInformation)
}
}

Expand Down Expand Up @@ -775,7 +775,7 @@ func main() {
// Initialize service logger
initializeLoggers(*flagParams.Service)
// Analyze version and compare with the latest release
checkLatestRelease()
go checkLatestRelease()
// Service starts!
osctrlAdminService()
Comment thread
javuto marked this conversation as resolved.
return nil
Expand Down
4 changes: 2 additions & 2 deletions cmd/api/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,9 @@ func checkLatestRelease() {
return
}
if version.CheckSuggestedRelease(latest.SuggestedRelease) {
log.Info().Msgf("%s is up to date with the latest release (%s)", serviceName, buildVersion)
log.Info().Msgf("%s (%s) is up to date with the suggested release (%s), latest %s", serviceName, buildVersion, latest.SuggestedRelease, latest.LatestRelease)
} else {
log.Info().Msgf("A newer version of %s is available: %s (current: %s)", serviceName, latest.SuggestedRelease, buildVersion)
log.Info().Msgf("Please upgrade %s to at least %s. Latest version available: %s (current: %s)", serviceName, latest.SuggestedRelease, latest.LatestRelease, buildVersion)
log.Info().Msgf("Release notes: %s", latest.MoreInformation)
}
}
Expand Down
Loading