Skip to content

Conversation

@gwennlbh
Copy link
Contributor

The site content is a docs site for a javascript library

@MattIPv4 MattIPv4 changed the title Add swarpc swarpc.js.org Dec 10, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/gwennlbh/swarpc/tree/gh-pages/docs

@MattIPv4
Copy link
Member

FYI I imagine you're going to want something at the root of your GitHub Pages deployment, whether its an actual page or a redirect, otherwise folks accessing the JS.org subdomain will get a 404 unless they know to go to the /docs directory -- this'll also cause your JS.org subdomain to get automatically flagged for cleanup as it will be seen as having no content.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Dec 10, 2025
@gwennlbh
Copy link
Contributor Author

Yea, i cant remember why i chose to deploy from / instead of /docs, i think i wanted to add live examples but never got around to it, thanks for the suggestion though ^^

@indus indus added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Dec 11, 2025
@indus
Copy link
Member

indus commented Dec 11, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line swarpc.js.org to make it work.
In case you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)
I'll merge after we have "contact". Please keep this PR open.

@gwennlbh
Copy link
Contributor Author

Thanks! Yeah I just needed to set the domain again in Pages settings, it's now live ^^

https://swarpc.js.org

gwennlbh added a commit to gwennlbh/swarpc that referenced this pull request Dec 11, 2025
@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Dec 12, 2025
@indus
Copy link
Member

indus commented Dec 12, 2025

Welcome https://swarpc.js.org

@indus indus merged commit 8b7dcc6 into js-org:master Dec 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants