Skip to content

Fix supports for AbstractOptimizerAttribute#196

Merged
odow merged 1 commit intomasterfrom
od/attribute
Jun 6, 2025
Merged

Fix supports for AbstractOptimizerAttribute#196
odow merged 1 commit intomasterfrom
od/attribute

Conversation

@odow
Copy link
Copy Markdown
Member

@odow odow commented Jun 6, 2025

Closes #195

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (1dd94d8) to head (f981873).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   92.90%   92.86%   -0.04%     
==========================================
  Files          14       14              
  Lines         747      743       -4     
==========================================
- Hits          694      690       -4     
  Misses         53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow odow merged commit 42b6ad3 into master Jun 6, 2025
8 checks passed
@odow odow deleted the od/attribute branch June 6, 2025 01:01
Comment thread src/MOI_wrapper.jl
end

function MOI.get(optimizer::DualOptimizer, ::MOI.PrimalStatus)
return MOI.get(optimizer.dual_problem.dual_model, MOI.DualStatus())
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odow I don't understand why we stopped transforming primal to dual in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Missing supports for AbstractOptimizerAttributes

2 participants