Skip to content

Fix supports for AbstractOptimizerAttribute #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 1 commit into from
Jun 6, 2025
Merged

Fix supports for AbstractOptimizerAttribute #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions src/MOI_wrapper.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,20 +467,11 @@ function _dual_status(term::MOI.TerminationStatusCode)
return term
end

function MOI.get(optimizer::DualOptimizer, ::MOI.ObjectiveValue)
return MOI.get(optimizer.dual_problem.dual_model, MOI.DualObjectiveValue())
end

function MOI.get(optimizer::DualOptimizer, ::MOI.DualObjectiveValue)
return MOI.get(optimizer.dual_problem.dual_model, MOI.ObjectiveValue())
end

function MOI.get(optimizer::DualOptimizer, ::MOI.PrimalStatus)
return MOI.get(optimizer.dual_problem.dual_model, MOI.DualStatus())
Copy link
Copy Markdown
Member

@blegat blegat Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odow I don't understand why we stopped transforming primal to dual in this PR

end

function MOI.get(optimizer::DualOptimizer, ::MOI.DualStatus)
return MOI.get(optimizer.dual_problem.dual_model, MOI.PrimalStatus())
function MOI.supports(
optimizer::DualOptimizer,
attr::MOI.AbstractOptimizerAttribute,
)
return MOI.supports(optimizer.dual_problem.dual_model, attr)
end

function MOI.set(
Expand All @@ -491,9 +482,14 @@ function MOI.set(
return MOI.set(optimizer.dual_problem.dual_model, attr, value)
end

function MOI.get(
optimizer::DualOptimizer,
attr::Union{MOI.AbstractModelAttribute,MOI.AbstractOptimizerAttribute},
)
function MOI.get(optimizer::DualOptimizer, attr::MOI.AbstractOptimizerAttribute)
return MOI.get(optimizer.dual_problem.dual_model, attr)
end

# For now we don't support setting arbitrary AbstractModelAttribute because
# we don't know if they need to be modified via the dualization. One example
# would be `MOI.set(model, MOI.ObjectiveFunction{F}(), f)`. We currently
# don't support the incremental interface.
function MOI.get(optimizer::DualOptimizer, attr::MOI.AbstractModelAttribute)
return MOI.get(optimizer.dual_problem.dual_model, attr)
end
1 change: 1 addition & 0 deletions test/Tests/test_MOI_wrapper.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@

@testset "attributes" begin
for optimizer in [dual_conic_optimizer; dual_linear_optimizer]
@test MOI.supports(optimizer, MOI.Silent())
before = MOI.get(optimizer, MOI.Silent())
MOI.set(optimizer, MOI.Silent(), !before)
@test MOI.get(optimizer, MOI.Silent()) == !before
Expand Down