Skip to content

Prep for v1.51.1#3005

Merged
odow merged 5 commits into
masterfrom
od/v1.51.1
May 29, 2026
Merged

Prep for v1.51.1#3005
odow merged 5 commits into
masterfrom
od/v1.51.1

Conversation

@odow
Copy link
Copy Markdown
Member

@odow odow commented May 26, 2026

Basic

  • version field of Project.toml has been updated
    - If a breaking change, increment the MAJOR field and reset others to 0
    - If adding new features, increment the MINOR field and reset PATCH to 0
    - If adding bug fixes or documentation changes, increment the PATCH field

Documentation

  • Add a new entry to docs/src/changelog.md, following existing style

Tests

@blegat
Copy link
Copy Markdown
Member

blegat commented May 26, 2026

We should first tag v1.51.1 without #3001, so that people see with the new tests that they don't implement bridge cost correctly, and then we add #3001 in v1.52

@odow
Copy link
Copy Markdown
Member Author

odow commented May 26, 2026

I regarded them both as a bug-fix. What's the problem with just making a single release? The only relevant failure is DiffOpt.

@blegat
Copy link
Copy Markdown
Member

blegat commented May 27, 2026

We might have failures in other packages that we don't test. Even if they are bug-fixes, that will break existing code.

@blegat
Copy link
Copy Markdown
Member

blegat commented May 27, 2026

So if you are developing an MOI layer and you use MOI.Test.runtests, you'll see that you have a bug when we release v1.15.1, then you have a head-start to fix it before we make the next release. The next release can be v1.15.2, it doesn't matter, we just need to give people a head-start

@odow
Copy link
Copy Markdown
Member Author

odow commented May 27, 2026

But wouldn’t the releases be a day apart anyway? There’s not much point in delaying. And it only really affects complicated layers, which most people are not writing.

@blegat
Copy link
Copy Markdown
Member

blegat commented May 27, 2026

We can wait a few days between v1.15.1 and v1.15.2. But if you're fine with it, we can also just release this, let's just first release new version of the four packages that we had to update (EDIT: done).

@blegat
Copy link
Copy Markdown
Member

blegat commented May 28, 2026

DiffOpt is fixed now that we released POI

Comment thread docs/src/changelog.md Outdated
@odow
Copy link
Copy Markdown
Member Author

odow commented May 28, 2026

I'm going to merge and tag this as-is.

@odow
Copy link
Copy Markdown
Member Author

odow commented May 28, 2026

JuliaFormatter changed: JuliaEditorSupport/JuliaFormatter.jl#1002

This is probably going to cause a lot of pain across jump-dev. I'll wait to see if it was intentional. If so, I'll make a separate PR updating the formatting. Before then I'll pin the version.

Comment thread .github/workflows/format_check.yml Outdated
Comment thread docs/src/changelog.md Outdated
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
@odow
Copy link
Copy Markdown
Member Author

odow commented May 29, 2026

Okay. I'm going to merge. I'll deal with the consequences.

@odow odow merged commit 75eaa7e into master May 29, 2026
30 checks passed
@odow odow deleted the od/v1.51.1 branch May 29, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants