🐛 Fix error with UnknownSet #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 47 47
Lines 4783 4783
=======================================
Hits 4567 4567
Misses 216 216
Continue to review full report at Codecov.
|
mlubin
reviewed
Oct 25, 2018
test/dummy.jl
Outdated
| @@ -1,9 +1,19 @@ | |||
| struct DummyModel <: MOI.ModelLike | |||
| # DummyModel{true} implements add_variable and add_constraint | |||
| struct DummyModel{A} <: MOI.ModelLike | |||
Member
There was a problem hiding this comment.
What about an abstract dummy model and two concrete subclasses to distinguish between the versions that implement add_variable or not. A boolean type parameter is hard to interpret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error makes LQOI fails with MOI v0.6.2 (see JuliaOpt/LinQuadOptInterface.jl#67). The PR adds a test to catch the error and fixes it.
The error comes from the fact that
UnknownSetis neither anAbstractScalarSetnor anAbstractVectorSethence a method error is thrown, see:https://github.com/JuliaOpt/MathOptInterface.jl/blob/00b5965ea1491a893af01c0bf8b5501a0f11c4bb/src/constraints.jl#L65-L88