Skip to content

Conversation

@blegat
Copy link
Member

@blegat blegat commented Nov 27, 2018

No description provided.

Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the doc build failure easy to fix?

@blegat
Copy link
Member Author

blegat commented Nov 27, 2018

I fixed the doc build in 0d4eccc

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #589 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          47       47           
  Lines        4871     4871           
=======================================
  Hits         4661     4661           
  Misses        210      210

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d4eccc...23921fc. Read the comment docs.

@blegat blegat merged commit c505245 into master Nov 27, 2018
@odow odow deleted the bl/v0.6.4 branch March 6, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants