Skip to content

Conversation

@odow
Copy link
Member

@odow odow commented Sep 26, 2019

Closes #903

@codecov-io
Copy link

codecov-io commented Sep 27, 2019

Codecov Report

Merging #904 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
+ Coverage   95.12%   95.12%   +<.01%     
==========================================
  Files          81       81              
  Lines        8592     8596       +4     
==========================================
+ Hits         8173     8177       +4     
  Misses        419      419
Impacted Files Coverage Δ
src/attributes.jl 87.37% <100%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e11c54...af6e67f. Read the comment docs.

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add it to docs/src/apireference.md

@blegat blegat added this to the v0.9.4 milestone Sep 29, 2019
@odow odow merged commit 16aa12f into master Sep 29, 2019
@odow odow deleted the od/callback_error branch September 29, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add specific error for incorrect callback usage

4 participants