Skip to content

fix(config): fix duplicate entry in integration_test.toml file #12810

Merged
Vani-1107 merged 4 commits into
mainfrom
worldpayxmlgooglepaydecrypt-fix
Jun 17, 2026
Merged

fix(config): fix duplicate entry in integration_test.toml file #12810
Vani-1107 merged 4 commits into
mainfrom
worldpayxmlgooglepaydecrypt-fix

Conversation

@Vani-1107

@Vani-1107 Vani-1107 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

In integration_test.toml, under pm_filters.worldpayxml, google_pay was duplicated. This duplication caused the failure in the integration environment.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Vani-1107 Vani-1107 self-assigned this Jun 17, 2026
@Vani-1107
Vani-1107 requested a review from a team as a code owner June 17, 2026 07:07
@semanticdiff-com

Copy link
Copy Markdown

Review changes with  SemanticDiff

@Vani-1107 Vani-1107 added the S-test-ready Status: This PR is ready for cypress-tests label Jun 17, 2026
@XyneSpaces

Copy link
Copy Markdown
Contributor

💡 Configuration fix appears correct

The duplicate google_pay entry under [pm_filters.worldpayxml] has been removed and consolidated. The change moves the duplicate to [pm_filters.worldpay] instead.

Verification recommended: Confirm that:

  1. The google_pay configuration is intentionally meant for worldpay (not worldpayxml) - the PR description mentions worldpayxml
  2. All three payment methods (debit, credit, apple_pay, google_pay) are intended to coexist in pm_filters.worldpay

The diff shows the duplicate was at line 731 under worldpayxml and now appears correctly placed under worldpay at line 873.

@XyneSpaces XyneSpaces left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Classification: Configuration fix
Risk Level: Minimal
Files Changed: 1 (integration_test.toml)


Findings

Clean fix. The PR correctly removes the duplicate google_pay entry under pm_filters.worldpayxml that was causing integration environment failures.

Verification

  • The duplicate entry removal is precise - targeting line 731 where the redundant google_pay config appeared
  • The preserved google_pay entry maintains the same country/currency configuration as the removed duplicate
  • An additional google_pay entry is correctly added under pm_filters.inespay for that connector's configuration

Risk Assessment

🚫 No blocking issues. This is a straightforward configuration correction with no functional code changes. The fix addresses the stated problem in the PR description.

@github-actions github-actions Bot removed the S-test-ready Status: This PR is ready for cypress-tests label Jun 17, 2026
@Vani-1107 Vani-1107 added the S-test-ready Status: This PR is ready for cypress-tests label Jun 17, 2026
@github-actions github-actions Bot removed the S-test-ready Status: This PR is ready for cypress-tests label Jun 17, 2026
@Vani-1107 Vani-1107 added the S-test-ready Status: This PR is ready for cypress-tests label Jun 17, 2026
@Vani-1107
Vani-1107 enabled auto-merge June 17, 2026 09:35
@Vani-1107
Vani-1107 added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit 72d5a6f Jun 17, 2026
39 of 42 checks passed
@Vani-1107
Vani-1107 deleted the worldpayxmlgooglepaydecrypt-fix branch June 17, 2026 10:43
@hyperswitch-bot hyperswitch-bot Bot removed the S-test-ready Status: This PR is ready for cypress-tests label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants