fix(connector): [WorldpayWPG] Add Mastercard in WASM for Payouts#12846
Conversation
XyneSpaces
left a comment
There was a problem hiding this comment.
Review Summary
This PR adds Mastercard support for Worldpay XML payouts across all environments. The changes are straightforward configuration additions.
Findings
✅ Consistency: The pattern follows the existing Visa configuration exactly - credit and debit entries are correctly paired.
✅ Completeness: Changes applied to all three environment files (development, production, sandbox) consistently.
Questions
-
WASM Implementation: Have you verified that the WASM/connector code in
euclid_wasmcan handle Mastercard forworldpayxml_payout? The TOML configs feed into the WASM engine for Control Center display - please confirm the payment method is recognized. -
Testing: The PR template indicates no unit tests were added. For a connector configuration change like this, consider:
- Verifying the connector can actually process Mastercard payouts through Worldpay XML
- Checking if there are any integration tests in
config/deployments/integration_test.tomlthat should be updated
Suggestion
Consider if other card networks (Amex, Discover, JCB) should also be supported for payouts to achieve parity with the main worldpayxml connector's capabilities.
No blocking issues identified. LGTM pending clarification on WASM validation.
| payment_method_type = "google_pay" | ||
| [[worldpayxml_payout.credit]] | ||
| payment_method_type = "Visa" | ||
| [[worldpayxml_payout.credit]] |
There was a problem hiding this comment.
Mastercard for worldpayxml_payout? The TOML feeds into euclid_wasm for Control Center connector configuration UI.
| payment_method_type = "google_pay" | ||
| [[worldpayxml_payout.credit]] | ||
| payment_method_type = "Visa" | ||
| [[worldpayxml_payout.credit]] |
There was a problem hiding this comment.
ℹ️ Note: Change mirrors development.toml - ensure testing was done in sandbox environment before promoting to production config.
🤖 Automated PR Review SummaryReviewed by: XyneSpaces Agent Files Changed
Key Findings
Overall AssessmentThe PR adds Mastercard payment method support for Worldpay XML payouts consistently across all environments. The pattern follows existing Visa configurations correctly. Status: ✅ Ready to merge after addressing minor questions This is an automated review. Please address inline comments for specific feedback. |
XyneSpaces
left a comment
There was a problem hiding this comment.
Review: WorldpayWPG Mastercard WASM Payout Support
Classification: connector-config · wasm-payouts
Risk Level: Low (configuration-only change)
Summary
Adds Mastercard support for Worldpay XML payout connector across all environments (dev, prod, sandbox).
Findings
⚠️ Verify connector transformer supports Mastercard
File: crates/hyperswitch_connectors/src/connectors/worldpaywpg/transformers.rs
This PR only updates TOML configs. Please verify that the WorldpayWPG connector transformer already handles Mastercard payout requests/responses correctly. The connector code may need updates for:
- Mastercard-specific error response mapping
- BIN range validation for payout eligibility
🔍 Nitpick: Inconsistent spacing in TOML
Files: All three TOML files
The added lines use 2-space indentation while surrounding code uses mixed formatting. Consider maintaining consistency:
[[worldpayxml_payout.credit]]
payment_method_type = "Mastercard"Verification Checklist
- Connector transformer tested with Mastercard payout flow
- Sandbox environment verified with test credentials
- Error responses properly mapped for Mastercard rejections
Overall Assessment
Configuration change is correct. Ensure the underlying connector implementation already supports Mastercard before merge.
Type of Change
Description
Add Mastercard in WASM for Payouts
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy