fix(core): populate connector_http_status_code on UCS PSync connector error

[AmitsinghTanwar007]

Closes #12986

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/router/src/core/payments/gateway/psync_gateway.rs	0% smaller

[XyneSpaces]

Review Summary

PR #12963 correctly propagates connector_http_status_code on UCS PSync connector errors. This is a straightforward fix that aligns error path behavior with the success path.

Analysis

Change: Adds router_data.connector_http_status_code = Some(status_code); in the UCS error handling branch of psync_gateway.rs.

Why this matters: The connector_http_status_code field is used for debugging and analytics. Previously, when UCS returned a connector error (e.g., 4xx/5xx from the downstream connector), this field would be None even though the HTTP status was available in the error response.

Code quality notes:

• The comment explaining the mirroring behavior is helpful
• The change is minimal and focused
• No breaking changes to the API or data model

One minor suggestion:

Consider adding a debug log when the status code is populated on the error path, similar to how other gateway operations log connector responses. This would help with troubleshooting in production:

logger::debug!(
    "UCS PSync error: connector_http_status_code={}",
    status_code
);

Overall, this is a clean fix that addresses a gap in error handling. ✅

[XyneSpaces]

Review comment on connector_http_status_code addition

[XyneSpaces]

[nit] This change mirrors #12971. Consider if both gateway files (authorize_gateway.rs and psync_gateway.rs) should share this logic via a common helper method to ensure consistent behavior across UCS error handling paths.