V0.21.0.rc2 #678
Closed
V0.21.0.rc2 #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* describe configs API implementation * remarks * remarks * remarks
* alter config * fix changelog * remarks * remarks * remarks
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* roll out ssl specs to public * Update .github/workflows/ci_linux_aarch64_gnu.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update .github/workflows/ci_linux_aarch64_gnu.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * remap incorrect port * run in ssl mode * more remarks --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* rename ci * increase time due to double rspec
* dont expose symbols * update changelog * use better toolchain * fix * build with gcc
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ry (#233) * ssl stress test * fix * wip * print debug * stress * try port * remarks * remarks * stress test with flush * print * install * wip * fix time * fix time * fix time * poc * poc * poc * poc * more ci aligned i hope * more ci aligned i hope * more ci aligned i hope * more ci aligned i hope * more ci aligned i hope * more ci aligned i hope * more ci aligned i hope * more time on ci * more time on ci * more time on ci * more time on ci * remarks * remarks * split to complementary * remarks * normalize names * add ubuntu complementary * remarks * add aarch64 gnu complementary * add last week split * remarks
* use mit mirror for krb5 * include sources due to outages * Update ext/build_common.sh Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Member
Author
|
argh bad target |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR is the release candidate for version 0.21.0 of the karafka-rdkafka gem, upgrading librdkafka to 2.11.0 and implementing various SSL testing improvements, new transaction features, and better error handling.
- Upgrade to librdkafka 2.11.0 with improved stability and new features
- Enhanced SSL testing infrastructure with SSL certificate generation and dual protocol support
- Complete transaction API implementation for producer operations with proper error handling
Reviewed Changes
Copilot reviewed 55 out of 79 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/rdkafka/version.rb | Version bump to 0.21.0.rc2 and librdkafka upgrade to 2.11.0 |
| spec/spec_helper.rb | Added SSL configuration support and increased test timeout |
| lib/rdkafka/producer.rb | Added complete transaction API methods and improved error handling |
| lib/rdkafka/error.rb | Enhanced error handling with detailed context and transaction state info |
| lib/rdkafka/bindings.rb | Added transaction FFI bindings and improved error handling functions |
| ext/generate-ssl-certs.sh | New SSL certificate generation script for testing |
| docker-compose-ssl.yml | New SSL-enabled Kafka configuration for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| (1..pointer_to_size_t.read_int).map do |ar| | ||
| self.class.new synonyms_ptr[ar - 1] | ||
| @synonyms << self.class.new(synonyms_ptr[ar - 1]) |
| producer2.close | ||
| end | ||
|
|
||
| it 'expect older producer not to be able to commit when fanced out' do |
There was a problem hiding this comment.
Typo in comment: 'fanced' should be 'fenced'.
Suggested change
| it 'expect older producer not to be able to commit when fanced out' do | |
| it 'expect older producer not to be able to commit when fenced out' do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.