fix: correctly parse PUSHER_USE_SSL environment variable (#6582) - #6680
Merged
Conversation
|
|
talboren
approved these changes
Aug 8, 2026
talboren
enabled auto-merge (squash)
August 8, 2026 08:15
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
talboren
disabled auto-merge
August 8, 2026 08:50
Contributor
|
🌈 Fantastic work @ChickenisLegit! Your very first PR to keep has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩💻👨💻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6582.
This PR fixes a bug where setting
PUSHER_USE_SSL=falsein Docker Compose or other environments would evaluate toTrue.This occurred because
os.environ.getreturns a string (e.g."false"), which evaluated toTruesince any non-empty string in Python evaluates toTruewhen checked againstFalse(e.g.ssl=False if os.environ.get("PUSHER_USE_SSL", False) is False else True).Changes
PUSHER_USE_SSLparsing to properly handle string booleans ("false","0","true","1","yes","on")."false"if the environment variable is not present, matching the existing fallback logic.