feat(media): cap group-room media by default - #752
Merged
Conversation
roborev: Combined Review (
|
Member
|
rebasing |
Beeper, Slack, Discord, and Teams now skip attachment downloads from conversations with more than 20 participants unless the operator sets media_max_participants. This keeps high-volume group rooms from consuming the archive's media budget while direct chats and small groups keep their media. An explicit media_max_participants = 0 still disables the cap. Skipped occurrences keep the participant_threshold marker, so backfill retries them only after the cap changes. This squashed change also includes: - feat(media): raise the chat media size default to 250 MiB The higher Beeper, Slack, and Teams size limit keeps long voice notes, screen recordings, and phone video from direct chats. Discord keeps its 50 MiB default, and an explicit max_media_mb remains unchanged. Refs kenn-io#634 kenn-io#620 kenn-io#632 kenn-io#648 Generated with Codex Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Codex <noreply@openai.com>
wesm
force-pushed
the
feat/issue-634-media-defaults
branch
from
September 4, 2026 02:36
7add6c7 to
39a2da0
Compare
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
participant_thresholdmarker, so backfill does not retry them until the cap changes. An explicitmedia_max_participants = 0still means no cap.media_scope,media_max_participants,max_media_mb,accounts_config, the per-guild Discord overrides, and a new[teams]section. The Beeper, Slack, Discord, and Teams usage pages describe the defaults.Why
Most attachment bytes in a real chat archive come from large rooms whose forwarded videos nobody wants kept, while the media worth keeping lives in direct chats and small groups. Capping group-room media by default keeps a fresh install from filling its disk with that volume, and once that volume is gone the low size cap no longer needs to act as a brake, so long voice notes, screen recordings, and phone video from direct chats fit.
Refs #634
Refs #620 #632
Usage
Nothing to do for the defaults. To collect from every room, or to change the caps:
Media already stored under an earlier policy stays until
msgvault purge-excluded-mediaruns; a raised cap makes the nextbackfill-*-mediarun retry files that now fit.🤖 Generated with Claude Code