NTV-188: Project story #1536
Merged
NTV-188: Project story #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* - first attempt HTMLParser * - query story from graph - generate as output the list of elements - commented for now the nested text components * - Migrated almost everything from the expriment * no message * - The ViewHolders are now KSViewHolders - Use databinding * no message * - code organization * - code organization * Revert "- code organization" This reverts commit 32c4219. * - Avoid duplicated workaround - Add Links to text links * - linter * - Added examples of project crashing
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: [no-jira]: automatize regression build (#1397)
* add Parser – Handle external sources * HTMLParserTest * Revert changes * Revert changes in file * Refactor code
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-278: UI pre-load polish (#1447)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-279: Update Facebook SKD Version (#1448)
…1449) * create ExternalViewViewHolder for ExternalSourceViewElement * Refactor to ConstraintLayout
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-276: Polish Project screen loading experience (#1450)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-286: Upgrade PerimeterX SDK to latest version (#1457)
* - images working nice * - removed unnecessary type * - Added tests for Images, Images with caption and Images with caption and Links + Gifs * Add extenation to load gif images * Create image with caption view with tests * Fix ui test * Update image view ext * Fix code format * Update screen shot Co-authored-by: Isabel Martin <arkariang@gmail.com>
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: no-jira: flaky tests around datetime failing on CI (#1459)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: - Update release versions and names after release
…1460) * Remove iframe white space * Hide caption in case its empty * Update width to 100% and remove youtube full screen control * Update screenshot test
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-261:Fetch and apply new translations (#1458)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-261 :Fetch and apply new translations (#1465)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-298:Layout breaking after entering pledge flow (#1466)
…nto feature/NTV-188-Project-Story
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-300: Update perimeter-x dependency (#1468)
* Fix Video Parser * update to extension
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: No-jira: Removed flaky test (#1471)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-298 : Layout breaking after entering pledge flow (#1469)
* smoothScrollToPosition after closing video or youtube in full screen * Fix ui
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-318: Update dependencies (#1486)
* - Lock in portrait * - clean memory
* Refactor the old video activity * Fix fullscreenButton * Fix crash * fix sync video issue * Remove unused projects * Fix code comment to refactor open
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-320: migrate to kotlin preferences package (#1489)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: Update internal and external version name and code after release
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-51 : Posting a reply (#1511) NTV-336: Project Model (#1510) NTV-50 :Posting a (root) comment (#1509) NTV-335: Backing model (#1508) Revert "- Backing body" - Backing body NTV-334: Reward model (#1505) # Conflicts: # app/src/main/java/com/kickstarter/models/Project.java
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: - version name, code after release
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-52 : Viewing (root) comments (#1513)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: Add comment_root_id to post comments (#1518) NTV-339: getProjects from GraphQL queries (#1516) NTV-53 :Viewing /Posting comment thread (#1517) NTV-351 Segment – Add project_url to properties (#1515) NTV-53:Viewing comment thread (#1514) # Conflicts: # app/src/main/java/com/kickstarter/services/KSApolloClient.kt
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-356: Joined queries to fecth projects (#1524) NTV-322 : ToggleProjectSave call from V1 to GraphQL (#1525) - version updates after release NTV-359: Fix pledge with Reward+AddOns that are shippable (#1523) Add watch project (#1522) NTV-357: Fix-crashes (#1521)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-367: Discovery drawer adapter (#1530)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: NTV-365 Migrate to Kotlin `DiscoveryAdapter.java` (#1531)
…ure/NTV-188-Project-Story * 'master' of github.com:kickstarter/android-oss: added percentage funded (#1535)
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
=========================================
Coverage 71.07% 71.07%
Complexity 442 442
=========================================
Files 171 171
Lines 4653 4653
Branches 258 258
=========================================
Hits 3307 3307
Misses 1274 1274
Partials 72 72 Continue to review full report at Codecov.
|
Arkariang
added a commit
that referenced
this pull request
Mar 3, 2022
…tin/NTV-319-Substitute-BoolSharedPrefs-BoolDataStore * 'master' of github.com:kickstarter/android-oss: (60 commits) NTV-366: DiscoveryParams migrated to kotlin and deprecated autoparcel (#1554) NTV-383: Migrate Message.java to kotlin and deprecate Autoparcel (#1551) NTV-415 :Jacoco code coverage only looking throw Java classes (#1550) NTV-399 Reply comments created with invalid commentable (#1549) NTV-414: /v1/activities was called from the app several times #1548 NTV-412: Hide old campaign links #1547 NTV-364: Discovery Activity fetchCategories from GraphQL (#1546) NTV-410: Upgrade stripe SDK (#1544) NTV-406: Remove old ProjectActivity and clean feature flag (#1543) NTV-395: UI – Out of place image captions (#1542) NTV-397: Clickable images on campaign (#1541) NTV-350 :Add Save Project deep link (#1540) NTV-360: Zoom on campaign images (#1539) Fix friend avatar issue (#1538) NTV-349 Add Save Project button to cards on Discovery (#1537) NTV-372: Update braze/segment dependency to 10.0.0 (#1532) NTV-188: Project story (#1536) added percentage funded (#1535) NTV-365 Migrate to Kotlin `DiscoveryAdapter.java` (#1531) NTV-367: Discovery drawer adapter (#1530) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Story 📖
NTV-188