fix #1
Merged
fix #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve change reporting for meraki_ssid - Documentation is more clear about dependencies - Not all change reports are accurate without new algorithm - Improved integration tests * Rename changelog fragment * Enable all tests in integration tests - Fix type merging * Add more integration tests for code coverage * Update URL creation
* update snmp modules to fix bugs for cloudengine * update snmp modules to fix bugs for cloudengine * update "ce_snmp_contact", list may be out range
* Split Avi Credentials into two parts - secrets and login_info * Fixed indentation issue * Removed trailing whitespaces * Added sub-options to avi credentials * Added sub-options to avi credentials * Updated argument specs to use fallback instead of getting defaults from environment variable
* update vxlan * add a changelog fragment for the PR 57264 * Update 57264-update-vxlan-to-fix-bugs.yml update for change request * Update ce_vxlan_vap.py remove commented codes.
* Default become plugins to core support * s/cache/become
Fixes #56137 - problem with Chassis/Power URI and GetChassisPower command - assemble URI from data in Chassis resource
To get all instances gcp_compute made a call to the Google API for each zone separately. Because of this if all zones needed to be queried fetching hosts lasted 30+ seconds. Now the module will use a single query that will return all the instances, so the execution should last just a few seconds. This commit also suppresses a warning from the google-auth library about using user credentials because if an Ansible user wants to use user credentials, there is no need to warn him about it.
* enable adjacent collections for ansible-doc
#57776) Added all variables that are also used by the gcp_* modules as described in the docs https://docs.ansible.com/ansible/latest/scenario_guides/guide_gce.html#providing-credentials-as-environment-variables
* vultr: deprecate vultr_ssh_key_facts * vultr: rename tests * vultr: adjust tests * vultr: new vultr_ssh_key_info module * vultr: test: vultr_ssh_key_info: improve tests * update docs
* Updated testcase * Added check mode support * Added check for mutual exclusive for Name and UUID Fixes: #57580 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* Actually run the unit tests and separate them into two files * Re-add recursion to merge_dicts() * Update tests to work with current code
…info (#54463) These openstacksdk calls are awkward special-case wrappers around patch_machine, and I would like to deprecate them in openstacksdk change https://review.openstack.org/647730. Use much simpler update_machine instead.
* Add a few examples of how to correctly use `regex_replace` filter because it behaves differently on different Python versions when using regex qualifiers that can match an empty string (e.g. '*', '?', etc).
…eck against tar archive file extension #56616. (#56617) Ansible galaxy role download checked for `.tar.gz`, but `tarfile.is_tarfile(...)` can identify and open any valid tarfile. This change uses transparent stream compression to make `.tar.gz` and `.tar.bz2` formats valid with python 2.6.x/2.7.x (as well as `.tar.xz` with python 3.x).
* assign a sane default to yum/dnf lock_timeout, in line with cli Fixes #57189 Signed-off-by: Adam Miller <admiller@redhat.com> * fix typo in changelog snippet Signed-off-by: Adam Miller <admiller@redhat.com>
Signed-off-by: Harald Albers <github@albersweb.de>
"name: ansible-storage-module" removed as name is not defined as parameter ##### ISSUE TYPE - Docs Pull Request +label: docsite_pr
* Initial proposal for new parameter option for response format - output_version parameter dictates the response key case - new is snake_case, old is camelCase - If new, conversion is done at the end of module execution - This is purely a proposal and not a final draft * Add support for ANSIBLE_MERAKI_FORMAT env var - If env var is set to 'camelcase' it will output camelcase - Otherwise, will default to snakecase - Added note to documentation fragment - As of now, all module documentation needs to be updated * Fix pep8 errors and remove output_version args * Restructure check in exit_json so it actually works * Add changelog fragment * Change output_format to a parameter with env var fallback - ANSIBLE_MERAKI_FORMAT is the valid env var - Added documentation * Convert to camel_dict_to_snake_dict() which is from Ansible - Fixed integration tests * Fix yaml lint error * exit_json camel_case conversion handles no data - exit_json would fail if data wasn't provided - Updated 3 integration tests for new naming convention * convert_camel_to_snake() handles lists and dicts - The native Ansible method doesn't handle first level lists - convert_camel_to_snake() acts simply as a wrapper for the method - There maybe a situation where nested lists are a problem, must test - Fixed integration tests in some modules * A few integration test fixes * Convert response documentation to snake case
* junos `get_configuration` netconf api expects the filter as instance of ElementTree object
Fixes: #22034 This patch adds support for a tls_version parameter that allows the TLS version used to be configurable. By default the module will let the underlying system libraries pick the maximum supported version. This parameter is useful for servers that are unable to support newer versions of TLS
* Update testing policy to be correct for RDS test suite * Create read replica in same region to avoid more permissions being required * Ensure modifying DB doesn't try to downgrade engine version * Add tags to main test suite to limit number of tests run for problem solving
* sysctl: fix 'err' referenced before assignment Fixes #58158 * Add changelog
* Add back _contains_vars method as maybe_template. Fixes #58282 * Remove template guard in a few places * maybe_template sounds like it might template something, rename to is_possibly_template * Add tests for is_possibly_template
* Update azure_rm_sqlfirewallrule related documentation
* Update azure_rm_sqlserver related documentation
The package_data globs in setup.py were missing the necessary glob to install: galaxy/data/default/.travis.yml A Python glob pattern will not by default match a hidden file (i.e. a file basename beginning with a dot). If you want a glob to pick up a hidden file in a directory you must explicitly specify a glob pattern with "/.*". Closes: #1777 Signed-off-by: John Dennis <jdennis@redhat.com>
typo in example command -- net_interface module accidentally listed as junos_interface
* win_pagefile - Fix idempotency when same settings as current * Fix tests and code * Fix problem with system managed * Fix again systemmanaged detection * Change check of systemmanged in creation * Fix readability and wrong flag for test
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
* Fix nested template test. There were two issues with the previous implementation: 1. The LOGNAME environment variable may not be set. 2. The comparison assumed that testhost is localhost. * Fix variable display for cartesian lookup test. * Fix vars list test. The test assumed that the ansible_user variable is always set, which is not guaranteed when using connections other than local. * Fix supervisorctl integration test. Use ansible_user_id instead of ansible_user since ansible_user is not guaranteed to be available when the connection is not local. * Fix file integration test. Use ansible_user_id instead of ansible_user since ansible_user is not guaranteed to be available when the connection is not local. * Fix expect integration test. Do not assume module_utils is available for utility scripts. * Fix python_requirements_info integration test. Check for pip instead of ansible, since ansible is not guaranteed to be installed when using a connection other than local. * Fix ansible-runner integration test. Use implicit localhost to run the test since it requires access to the ansible installation currently being tested. * Fix tower_common integration test. Accept errors on stdout or stderr. * Fix tower_user integration test. Recognize errors on stdout or stderr.
* Fix service integration test. Set the proper file mode when copying before asserting the mode is correct. * Fix certificate_complete_chain test. Do not assume that testhost is the same as localhost.
…7518) * tower_role: ensure alias of validate_certs is handled * tower modules: remove tower_verify_ssl alias too Error was: Failed to update role: The Tower server claims it was sent a bad request. GET https://tower/api/v2/projects/22/object_roles/ Params: [('tower_verify_ssl', False), ('role_field', 'admin_role')] Data: None Response: {"detail": "Role has no field named 'tower_verify_ssl'"} Full traceback: File "/tmp/ansible_tower_role_payload_7_2p0X/__main__.py", line 145, in main result = role.grant(**params) File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 365, in grant return self.role_write(fail_on_found=fail_on_found, **kwargs) File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 242, in role_write fail_on_multiple_results=True, **data) File "/usr/local/lib/python2.7/dist-packages/tower_cli/models/base.py", line 301, in read r = client.get(url, params=params) File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 546, in get return self.request('GET', url, **kwargs) File "/usr/local/lib/python2.7/dist-packages/tower_cli/api.py", line 299, in request kwargs.get('data', None), r.content.decode('utf8'))
* Documentation update * Typo fixes * fail_json fixes Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* dnsimple: fix missing defaults and doc * fix sanity
When provided with a wrong password `rabbitmqctl authenticate_user` returns a non-zero exit code (65). This seems to be unexpected by the module and it fails when `update_password` is set to 'always'. To mitigate this behavior we augment the `_exec` method by adding a `check_rc` flag (which defaults to `True`, hence it's backward-compatible) and override it when we need it (in `check_password` method to address #56164).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION