refactor(assetregistry): close prompt module - #274
Merged
Conversation
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe pull request reorganizes asset registry packages, introduces prompt operations contracts, isolates prompt internals, and updates assistant wiring and tests. It also adds Spring Modulith boundary checks and moves ChangesAsset Registry Modularization
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant AssistantAssetToolService
participant PromptAssistantOperations
participant AssetReleaseUseQuery
participant PromptTemplateRenderer
AssistantAssetToolService->>PromptAssistantOperations: preparePrompt(actor, assetId, releaseId)
PromptAssistantOperations->>AssetReleaseUseQuery: authorize and retrieve prompt release
PromptAssistantOperations->>PromptTemplateRenderer: parse prompt payload
PromptAssistantOperations-->>AssistantAssetToolService: return PromptPreparationResult
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format Release preview
This PR does not add changelog files. Pending changelogs from other branches are included in the preview above. Run Managed by Tegami. |
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptPreparationService.java`:
- Around line 33-42: Replace the name-based conversion in
PromptPreparationService’s variable mapping with an explicit converter from the
specification variable type to PromptPreparationResult.VariableType, defining
each supported mapping and handling unsupported values deliberately. Use the
converter when constructing PromptPreparationResult.Variable and add tests
covering the public variable-type contract.
- Around line 10-11: Change the PromptPreparationService class declaration from
public to package-private by removing the public modifier. Leave its
construction and Spring wiring unchanged, preserving public visibility only for
PromptAssistantOperations and PromptPreparationResult.
In
`@core/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptPreparationResult.java`:
- Around line 13-22: Update the PromptPreparationResult canonical constructor to
recursively freeze nested map/list JSON values in outputContract and each
Variable.defaultValue, rather than only copying the outer collections. Preserve
scalar values and reject or consistently handle unsupported mutable value types,
then add tests covering nested input mutation and attempted mutation through
accessors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0ecbe90d-b1de-42e4-89d4-c560eeea9826
⛔ Files ignored due to path filters (3)
docs/increments/active/2026-07-31-spring-modulith-package-refactor/assetregistry-prompt-challenge-verdict.mdis excluded by!docs/**docs/increments/active/2026-07-31-spring-modulith-package-refactor/design.mdis excluded by!docs/**docs/increments/active/2026-07-31-spring-modulith-package-refactor/plan.mdis excluded by!docs/**
📒 Files selected for processing (66)
apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetConsumptionControllerTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetDeliveryControllerSecurityTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/SkillDistributionControllerTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetCatalogReadModelRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetDeliveryRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetDeliveryService.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRecommendation.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryCoordinator.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryService.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseAvailabilityEvent.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetTypeProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetTypeProfileRegistry.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetView.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackDefinition.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackService.javacore/src/main/java/com/orgmemory/core/assetregistry/PackJourney.javacore/src/main/java/com/orgmemory/core/assetregistry/PromptRunStatus.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillDistributionService.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillInstallManifest.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillPackageProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/WorkInstructionProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/WorkInstructionService.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetAvailability.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetConsumptionRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetPublicationMode.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetReleaseUseQuery.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/profile/AssetPayloadProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/profile/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptAssistantOperationsAdapter.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationComparison.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationResult.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRun.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRunRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptExecutionService.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptPreparationService.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRun.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunCoordinator.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunStatus.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateRenderer.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateSpec.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptAssistantOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptPreparationResult.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptRenderResult.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptRunResult.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/package-info.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAssetToolService.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAssetTraceRecorder.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetProfileValidationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetValidationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/CapabilityPackServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillDistributionServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/prompt/PromptExecutionServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateRendererTests.javacore/src/test/java/com/orgmemory/core/assistant/AssistantAssetToolServiceTests.java
💤 Files with no reviewable changes (1)
- core/src/main/java/com/orgmemory/core/assetregistry/PromptRunStatus.java
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: Backend · Java 25
🧰 Additional context used
📓 Path-based instructions (3)
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Treat the repository and runtime evidence as the engineering system of record; do not treat chat or Northstar as authoritative.
Before changing a domain, read its specification, test-coverage document, and applicable decision filenames.
Material decisions about domain boundaries, authorization, persistence, publication, concurrency, cache isolation, parity scope, or deployment require an independent architecture challenge and documented alternatives before implementation.
Do not use completed increment documents as the source for current behavior; use them only for history or archaeology.
Before using unfamiliar Spring Boot, Spring Modulith, Spring AI, Gradle, React, Vite, Tailwind, TypeScript, Next.js, or Fumadocs APIs, consult current official documentation, Context7, and the relevant verification skill.
Readdocs/guidelines/agent-safety.mdbefore retrieval, AI, MCP, permission, upload, graph, or export work; never commit secrets or customer data.
Keepddl-auto=validateand pair every persisted-model change with a Flyway migration.
Use the testing harness; a terminating clean test is the JVM context gate, andbootRunis not verification.
Files:
core/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseAvailabilityEvent.javacore/src/main/java/com/orgmemory/core/assetregistry/PackJourney.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRunRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/WorkInstructionProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationResult.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryCoordinator.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptRunResult.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetConsumptionRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/WorkInstructionService.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationComparison.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunStatus.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptRenderResult.javacore/src/main/java/com/orgmemory/core/assetregistry/profile/AssetPayloadProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/profile/package-info.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetAvailability.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillInstallManifest.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetPublicationMode.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/package-info.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillDistributionService.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetReleaseUseQuery.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillPackageProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetTypeProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetTypeProfileRegistry.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateProfile.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/SkillDistributionControllerTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetDeliveryRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetDeliveryService.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackService.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRun.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRun.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetDeliveryControllerSecurityTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRecommendation.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackDefinition.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptPreparationService.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetCatalogReadModelRepository.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetValidationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseRepository.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetConsumptionControllerTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillDistributionServiceTests.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAssetTraceRecorder.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateSpec.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptPreparationResult.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryService.javacore/src/test/java/com/orgmemory/core/assetregistry/CapabilityPackServiceTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetView.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptAssistantOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunCoordinator.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptAssistantOperationsAdapter.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAssetToolService.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateRenderer.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetProfileValidationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptExecutionService.javacore/src/test/java/com/orgmemory/core/assetregistry/prompt/PromptExecutionServiceTests.javacore/src/test/java/com/orgmemory/core/assistant/AssistantAssetToolServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateRendererTests.java
**/*.java
📄 CodeRabbit inference engine (AGENTS.md)
Apply IDE inspection only to edited backend Java files.
Files:
core/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseAvailabilityEvent.javacore/src/main/java/com/orgmemory/core/assetregistry/PackJourney.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRunRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/WorkInstructionProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationResult.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryCoordinator.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptRunResult.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetConsumptionRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/WorkInstructionService.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationComparison.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunStatus.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptRenderResult.javacore/src/main/java/com/orgmemory/core/assetregistry/profile/AssetPayloadProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/profile/package-info.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetAvailability.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillInstallManifest.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetPublicationMode.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/package-info.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillDistributionService.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetReleaseUseQuery.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/SkillPackageProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetTypeProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetTypeProfileRegistry.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateProfile.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/SkillDistributionControllerTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetDeliveryRelease.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetDeliveryService.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackService.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRun.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRun.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetDeliveryControllerSecurityTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRecommendation.javacore/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackDefinition.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptPreparationService.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetCatalogReadModelRepository.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetValidationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseRepository.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetConsumptionControllerTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillDistributionServiceTests.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAssetTraceRecorder.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateSpec.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptPreparationResult.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryService.javacore/src/test/java/com/orgmemory/core/assetregistry/CapabilityPackServiceTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetView.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptAssistantOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunCoordinator.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptAssistantOperationsAdapter.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/main/java/com/orgmemory/core/assistant/AssistantAssetToolService.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateRenderer.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetProfileValidationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptExecutionService.javacore/src/test/java/com/orgmemory/core/assetregistry/prompt/PromptExecutionServiceTests.javacore/src/test/java/com/orgmemory/core/assistant/AssistantAssetToolServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateRendererTests.java
apps/api/src/main/java/**/*.java
⚙️ CodeRabbit configuration file
apps/api/src/main/java/**/*.java: Enforce the browser-BFF and resource-server boundaries. Authentication
must resolve an active internal actor through the explicit issuer and
subject binding. Reject identity, tenant, roles, or permissions supplied
by request payloads, JWT email, or untrusted JWT role claims.
Files:
apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.java
🧠 Learnings (2)
📚 Learning: 2026-08-02T08:30:57.335Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 270
File: core/src/main/java/com/orgmemory/core/assetregistry/AssetDraftRepository.java:15-23
Timestamp: 2026-08-02T08:30:57.335Z
Learning: For OrgMemory JPA repository methods using `PESSIMISTIC_WRITE`, do not add a finite lock-timeout hint as part of a behavior-preserving refactor. The V1 PostgreSQL configuration uses `lock_timeout = 0`; any finite lock timeout must be established as a platform-wide database and transaction policy rather than configured on an individual method.
Applied to files:
core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRunRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetCatalogReadModelRepository.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseRepository.java
📚 Learning: 2026-07-26T05:46:47.443Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 61
File: apps/mcp/src/main/java/com/orgmemory/mcp/McpSecurityConfiguration.java:50-52
Timestamp: 2026-07-26T05:46:47.443Z
Learning: In OrgMemory, treat the `apps/mcp` and `apps/api` as independent protocol adapter modules. When adjusting OAuth/wire-level scopes, do not introduce a shared Java constant or create a code dependency from `apps/mcp` to `apps/api` solely to deduplicate scope values. Instead, keep OAuth/scope constants adapter-local (e.g., in the relevant adapter/security configuration classes) and ensure cross-adapter consistency via automated realm/OAuth/authorization tests, rather than via shared wiring-level constants or cross-module references.
Applied to files:
apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javaapps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.java
🔇 Additional comments (65)
apps/api/src/main/java/com/orgmemory/api/assistant/AssistantConfiguration.java (1)
12-12: LGTM!Also applies to: 107-121
core/src/main/java/com/orgmemory/core/assistant/AssistantAssetToolService.java (1)
4-15: LGTM!Also applies to: 30-48, 105-129, 132-150, 153-189, 379-392
core/src/main/java/com/orgmemory/core/assistant/AssistantAssetTraceRecorder.java (1)
3-3: LGTM!apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.java (1)
10-11: LGTM!apps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.java (1)
25-30: LGTM!Also applies to: 40-42
apps/api/src/test/java/com/orgmemory/api/assetregistry/SkillDistributionControllerTests.java (1)
13-14: LGTM!apps/api/src/test/java/com/orgmemory/api/assetregistry/AssetConsumptionControllerTests.java (1)
12-15: LGTM!apps/api/src/test/java/com/orgmemory/api/assetregistry/AssetDeliveryControllerSecurityTests.java (1)
8-8: LGTM!core/src/test/java/com/orgmemory/core/assistant/AssistantAssetToolServiceTests.java (1)
20-23: LGTM!Also applies to: 38-63, 107-153, 169-176
core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java (1)
1081-1081: LGTM!Also applies to: 1161-1191, 1193-1214, 1216-1236, 1238-1265, 1267-1285, 1287-1307
core/src/test/java/com/orgmemory/core/assetregistry/AssetProfileValidationTests.java (1)
9-29: LGTM!Also applies to: 39-39, 84-84
core/src/test/java/com/orgmemory/core/assetregistry/AssetValidationTests.java (1)
3-3: LGTM!core/src/test/java/com/orgmemory/core/assetregistry/CapabilityPackServiceTests.java (1)
9-11: LGTM!core/src/test/java/com/orgmemory/core/assetregistry/SkillDistributionServiceTests.java (1)
16-18: LGTM!core/src/test/java/com/orgmemory/core/assetregistry/prompt/PromptExecutionServiceTests.java (1)
1-1: LGTM!Also applies to: 19-25, 44-62, 101-101, 156-175
core/src/test/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateRendererTests.java (1)
1-8: LGTM!Also applies to: 64-83
core/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetAvailability.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetConsumptionRelease.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetPublicationMode.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/consumption/AssetReleaseUseQuery.java (1)
1-22: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptAssistantOperationsAdapter.java (1)
1-82: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationComparison.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationResult.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRun.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptEvaluationRunRepository.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptExecutionService.java (1)
1-12: LGTM!Also applies to: 37-37, 47-54, 67-68, 88-98
core/src/main/java/com/orgmemory/core/assetregistry/consumption/package-info.java (1)
1-3: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/profile/AssetPayloadProfile.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/profile/package-info.java (1)
1-3: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryService.java (1)
3-6: LGTM!Also applies to: 32-32, 278-278
core/src/main/java/com/orgmemory/core/assetregistry/AssetCatalogReadModelRepository.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptPreparationService.java (1)
1-9: LGTM!Also applies to: 12-32, 43-48
core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRun.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunCoordinator.java (2)
1-4: LGTM!
13-13: 🩺 Stability & AvailabilityNo change needed for transactional visibility.
Spring Boot 4.1.0 provides Spring Framework 7.x, and this code uses class-based
@Servicebeans rather than interfaces.core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunRepository.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptRunStatus.java (1)
1-7: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetDeliveryRelease.java (1)
3-6: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetDeliveryService.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetRecommendation.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryCoordinator.java (1)
3-6: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetRelease.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateProfile.java (1)
1-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateRenderer.java (1)
1-1: LGTM!Also applies to: 19-19, 38-42, 188-188
core/src/main/java/com/orgmemory/core/assetregistry/prompt/PromptTemplateSpec.java (1)
1-1: LGTM!Also applies to: 10-10
core/src/main/java/com/orgmemory/core/assetregistry/prompt/package-info.java (1)
1-15: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptAssistantOperations.java (1)
1-26: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseAvailabilityEvent.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetReleaseRepository.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetTypeProfile.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetTypeProfileRegistry.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/AssetView.java (1)
3-5: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptRenderResult.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/promptcontract/PromptRunResult.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/promptcontract/package-info.java (1)
1-3: LGTM!apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.java (1)
12-16: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackDefinition.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackProfile.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/CapabilityPackService.java (1)
3-5: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/PackJourney.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/SkillDistributionService.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/SkillInstallManifest.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/SkillPackageProfile.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/WorkInstructionProfile.java (1)
3-4: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/WorkInstructionService.java (1)
3-4: LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assetregistry.promptaround Prompt schema, rendering, execution, and persistenceprofile,consumption, andpromptinterfaces so Assistant stays outside the nested moduleVerification
ModulithVerificationTests, then 67/67 structure tests greenOpenApiContractTestsunchanged and greenpython scripts/check_docs.py(515 Markdown files, 8 mirrored pairs)pnpm release:checkon exact Node 24.15.0 (18 + 23 tests)clean test: 99 tasks in 7m05sskip-release: intermediate modular refactor; release follows completion of the full refactor goal
Summary by CodeRabbit