refactor(assetregistry): close skill semantics module - #283
Conversation
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR modularizes ChangesSkill module boundary
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format Release preview
This PR does not add changelog files. Pending changelogs from other branches are included in the preview above. Run Managed by Tegami. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRegistryService.java (1)
82-84: 🚀 Performance & Scalability | 🟠 Major | 🏗️ Heavy liftRemove the redundant
requireCreatechecks from the registry imports.
SkillGitHubImportService.importSelectedcallspackages.requireCreate(actor, request.source().knowledgeSpaceId)once, then callsskills.importPackage(...)for each selected package.SkillRegistryService.importPackagethen callspackages.requireCreate(actor, knowledgeSpaceId)again before invokingpackages.importPackage(...), which repeatsassets.requireSkillCreate(...). The same duplicate authorization path exists forreplacePackage/requireEdit. Keep the permission check on the persistence command and remove the wrapper calls.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRegistryService.java` around lines 82 - 84, Remove the redundant packages.requireCreate call from SkillRegistryService.importPackage, and remove the corresponding packages.requireEdit wrapper check from replacePackage. Keep authorization in the underlying packages.importPackage persistence command while preserving the existing actor and classification validation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetRegistryController.java`:
- Around line 270-283: Update the result mapping in AssetRegistryController to
resolve each imported item independently without allowing assets.get to abort
the overall ImportResult. Preserve successful per-item results, and convert any
resolution failure into that item's errorCode/errorMessage while retaining its
path and imported status. Avoid the current per-item full AssetView read pattern
where possible by reusing import results or a batch/minimal resolution path
exposed by the import services.
In
`@core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRegistryServiceTests.java`:
- Around line 115-140: The existing replacement test does not verify
authorization occurs before reading the upload. Add a separate unauthorized test
near replacementAuthorizesBeforeReadingAndRoutesTheCanonicalUpload that
configures requireEdit(ACTOR, ASSET_ID) to throw the expected authorization
exception, invokes replacePackage with an UnreadableInputStream, and asserts
that exception; keep the existing authorized routing assertions unchanged.
---
Outside diff comments:
In
`@core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRegistryService.java`:
- Around line 82-84: Remove the redundant packages.requireCreate call from
SkillRegistryService.importPackage, and remove the corresponding
packages.requireEdit wrapper check from replacePackage. Keep authorization in
the underlying packages.importPackage persistence command while preserving the
existing actor and classification validation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 42dbb7ab-4858-4a17-8efa-753a93eee423
⛔ Files ignored due to path filters (4)
docs/increments/active/2026-07-31-spring-modulith-package-refactor/design.mdis excluded by!docs/**docs/increments/active/2026-07-31-spring-modulith-package-refactor/plan.mdis excluded by!docs/**docs/specs/domains/asset-registry.mdis excluded by!docs/**docs/tests/domains/asset-registry.mdis excluded by!docs/**
📒 Files selected for processing (43)
ARCHITECTURE.mdapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetRegistryController.javaapps/api/src/test/java/com/orgmemory/api/SkillCapabilityBoundaryTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetConsumptionControllerTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetDeliveryControllerSecurityTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/SkillDistributionControllerTests.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryCoordinator.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillDistributionOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillDistributionService.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubImportService.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubSourcePort.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillInstallManifest.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageContent.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspection.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspector.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageProfile.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageSpec.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageValidationException.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRegistryService.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/skillpackage/SkillPackagePayloadPolicy.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetProfileValidationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillDistributionServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillPackageAssetServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillRegistryServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillDistributionServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillGitHubImportServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspectorTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillPackageProfileTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRegistryServiceTests.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubConnectorAutoConfiguration.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubSkillArchiveReader.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubSkillSourceAdapter.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubConnectorAutoConfigurationTests.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubSkillArchiveReaderTests.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubSkillSourceAdapterTests.java
💤 Files with no reviewable changes (2)
- core/src/test/java/com/orgmemory/core/assetregistry/SkillDistributionServiceTests.java
- core/src/test/java/com/orgmemory/core/assetregistry/SkillRegistryServiceTests.java
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: Web · Node 24
- GitHub Check: Backend · Java 25
🧰 Additional context used
📓 Path-based instructions (3)
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Treat the repository and runtime evidence as the engineering system of record; do not treat chat or Northstar as authoritative.
Before changing a domain, read its specification, test-coverage document, and applicable decision filenames.
Material decisions about domain boundaries, authorization, persistence, publication, concurrency, cache isolation, parity scope, or deployment require an independent architecture challenge and documented alternatives before implementation.
Do not use completed increment documents as the source for current behavior; use them only for history or archaeology.
Before using unfamiliar Spring Boot, Spring Modulith, Spring AI, Gradle, React, Vite, Tailwind, TypeScript, Next.js, or Fumadocs APIs, consult current official documentation, Context7, and the relevant verification skill.
Readdocs/guidelines/agent-safety.mdbefore retrieval, AI, MCP, permission, upload, graph, or export work; never commit secrets or customer data.
Keepddl-auto=validateand pair every persisted-model change with a Flyway migration.
Use the testing harness; a terminating clean test is the JVM context gate, andbootRunis not verification.
Files:
core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillPackageProfileTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillDistributionOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageOperations.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillDistributionServiceTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspector.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubConnectorAutoConfiguration.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubSkillArchiveReader.javaapps/api/src/test/java/com/orgmemory/api/SkillCapabilityBoundaryTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skillpackage/SkillPackagePayloadPolicy.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubConnectorAutoConfigurationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillInstallManifest.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRegistryServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspectorTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetDeliveryControllerSecurityTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageProfile.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubSkillArchiveReaderTests.javaARCHITECTURE.mdcore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageContent.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryServiceTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetConsumptionControllerTests.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubSourcePort.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageValidationException.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubSkillSourceAdapterTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspection.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillDistributionService.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/SkillDistributionControllerTests.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageSpec.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillPackageAssetServiceTests.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubSkillSourceAdapter.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryCoordinator.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetProfileValidationTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillGitHubImportServiceTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRegistryService.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubImportService.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetRegistryController.java
**/*.java
📄 CodeRabbit inference engine (AGENTS.md)
Apply IDE inspection only to edited backend Java files.
Files:
core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillPackageProfileTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/package-info.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillDistributionOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageOperations.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillDistributionServiceTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubOperations.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspector.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubConnectorAutoConfiguration.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubSkillArchiveReader.javaapps/api/src/test/java/com/orgmemory/api/SkillCapabilityBoundaryTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skillpackage/SkillPackagePayloadPolicy.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubConnectorAutoConfigurationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillInstallManifest.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRegistryServiceTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspectorTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetDeliveryControllerSecurityTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageProfile.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubSkillArchiveReaderTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageContent.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryServiceTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetConsumptionControllerTests.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubSourcePort.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageValidationException.javaintegrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubSkillSourceAdapterTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspection.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillDistributionService.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/SkillDistributionControllerTests.javacore/src/test/java/com/orgmemory/core/ModulithVerificationTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageSpec.javacore/src/test/java/com/orgmemory/core/assetregistry/SkillPackageAssetServiceTests.javaintegrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubSkillSourceAdapter.javacore/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryCoordinator.javacore/src/test/java/com/orgmemory/core/assetregistry/AssetProfileValidationTests.javaapps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.javacore/src/test/java/com/orgmemory/core/assetregistry/skill/SkillGitHubImportServiceTests.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRegistryService.javacore/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubImportService.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetRegistryController.java
apps/api/src/main/java/**/*.java
⚙️ CodeRabbit configuration file
apps/api/src/main/java/**/*.java: Enforce the browser-BFF and resource-server boundaries. Authentication
must resolve an active internal actor through the explicit issuer and
subject binding. Reject identity, tenant, roles, or permissions supplied
by request payloads, JWT email, or untrusted JWT role claims.
Files:
apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetRegistryController.java
🧠 Learnings (1)
📚 Learning: 2026-07-26T05:46:47.443Z
Learnt from: kl3inIT
Repo: kl3inIT/OrgMemory PR: 61
File: apps/mcp/src/main/java/com/orgmemory/mcp/McpSecurityConfiguration.java:50-52
Timestamp: 2026-07-26T05:46:47.443Z
Learning: In OrgMemory, treat the `apps/mcp` and `apps/api` as independent protocol adapter modules. When adjusting OAuth/wire-level scopes, do not introduce a shared Java constant or create a code dependency from `apps/mcp` to `apps/api` solely to deduplicate scope values. Instead, keep OAuth/scope constants adapter-local (e.g., in the relevant adapter/security configuration classes) and ensure cross-adapter consistency via automated realm/OAuth/authorization tests, rather than via shared wiring-level constants or cross-module references.
Applied to files:
apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.javaapps/api/src/main/java/com/orgmemory/api/assetregistry/AssetRegistryController.java
🔇 Additional comments (43)
ARCHITECTURE.md (1)
218-227: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillDistributionOperations.java (1)
1-19: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubSourcePort.java (2)
1-1: LGTM!Also applies to: 42-46
56-60: 🗄️ Data Integrity & IntegrationNo remaining
SkillPackageSpec.Visibilityreferences.core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillInstallManifest.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageContent.java (1)
1-1: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspection.java (1)
1-1: LGTM!Also applies to: 16-24
core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageSpec.java (1)
1-9: LGTM!Also applies to: 59-59
core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillDistributionService.java (1)
1-1: LGTM!Also applies to: 17-17, 32-32, 42-42, 59-59
apps/api/src/test/java/com/orgmemory/api/assetregistry/SkillDistributionControllerTests.java (1)
15-17: LGTM!Also applies to: 49-50, 90-91
core/src/test/java/com/orgmemory/core/assetregistry/SkillReleaseDeliveryServiceTests.java (1)
1-213: LGTM!core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillDistributionServiceTests.java (1)
1-187: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubOperations.java (1)
9-95: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageOperations.java (1)
8-27: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillRegistryService.java (1)
20-31: LGTM!Also applies to: 33-54, 56-72, 107-113, 125-129
core/src/main/java/com/orgmemory/core/assetregistry/AssetRegistryCoordinator.java (2)
3-4: LGTM!Also applies to: 61-61, 82-82, 184-185, 465-466, 540-546, 765-766, 847-848, 1159-1161
1174-1187: 🎯 Functional CorrectnessNo change needed.
AssetPayloadReference.getContentLength()is boxed, butSkillPackageArtifact.contentLength()is primitivelong, soreference.getContentLength() != artifact.contentLength()unboxes the reference before comparing values.> Likely an incorrect or invalid review comment.core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillGitHubImportService.java (1)
1-3: LGTM!Also applies to: 23-38, 40-48, 50-54, 90-97, 140-152
apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetRegistryController.java (1)
15-18: LGTM!Also applies to: 58-71, 128-131, 141-154, 197-205, 234-234, 245-245, 298-305
apps/api/src/test/java/com/orgmemory/api/assetregistry/AssetRegistryIntegrationTests.java (1)
44-44: LGTM!Also applies to: 152-152, 1019-1019, 1060-1060, 1069-1075, 1104-1104, 1132-1132, 1213-1213, 1632-1642
core/src/test/java/com/orgmemory/core/assetregistry/AssetProfileValidationTests.java (1)
31-45: LGTM!Also applies to: 152-152
core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageProfile.java (1)
1-1: 🗄️ Data Integrity & IntegrationNo cross-package references to
SkillPackageProfileremain.All
SkillPackageProfileusages are in thecore/src/main/java/com/orgmemory/core/assetregistry/skillpackage or string-based module test registrations, so the package-private type remains accessible only through the intended co-located components/interfaces.core/src/main/java/com/orgmemory/core/assetregistry/skillpackage/SkillPackagePayloadPolicy.java (1)
6-7: 🗄️ Data Integrity & IntegrationNo issue.
Only
SkillPackageProfileimplementsSkillPackagePayloadPolicy, and it definesartifact(String canonicalPayload); test usage mocks the interface instead of implementing it.core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspector.java (1)
1-1: LGTM!core/src/test/java/com/orgmemory/core/ModulithVerificationTests.java (1)
1248-1261: LGTM!Also applies to: 1291-1369
core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillGitHubImportServiceTests.java (1)
1-1: LGTM!Also applies to: 15-15, 45-45, 55-154, 170-175, 188-212, 235-235
core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillPackageInspectorTests.java (1)
1-1: LGTM!core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillPackageProfileTests.java (1)
1-33: LGTM!core/src/test/java/com/orgmemory/core/assetregistry/skill/SkillRegistryServiceTests.java (1)
1-112: LGTM!Also applies to: 142-170
integrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubConnectorAutoConfiguration.java (1)
3-3: LGTM!integrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubSkillArchiveReader.java (1)
3-3: LGTM!integrations/connectors/src/main/java/com/orgmemory/connectors/github/GitHubSkillSourceAdapter.java (1)
3-3: LGTM!Also applies to: 99-99, 124-124, 200-202, 438-438
integrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubSkillArchiveReaderTests.java (1)
6-6: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/package-info.java (1)
1-14: LGTM!apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetConsumptionController.java (1)
17-18: LGTM!Also applies to: 49-57
apps/api/src/main/java/com/orgmemory/api/assetregistry/AssetDeliveryController.java (1)
12-13: LGTM!Also applies to: 48-54
apps/api/src/test/java/com/orgmemory/api/assetregistry/AssetConsumptionControllerTests.java (1)
16-17: LGTM!Also applies to: 49-50, 72-73, 89-91
apps/api/src/test/java/com/orgmemory/api/assetregistry/AssetDeliveryControllerSecurityTests.java (1)
9-9: LGTM!Also applies to: 96-97, 106-112
core/src/test/java/com/orgmemory/core/assetregistry/SkillPackageAssetServiceTests.java (1)
4-17: LGTM!Also applies to: 84-166, 177-178, 226-239
integrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubConnectorAutoConfigurationTests.java (1)
8-8: LGTM!Also applies to: 56-62
integrations/connectors/src/test/java/com/orgmemory/connectors/github/GitHubSkillSourceAdapterTests.java (1)
16-16: LGTM!Also applies to: 81-81, 141-141
apps/api/src/test/java/com/orgmemory/api/SkillCapabilityBoundaryTests.java (1)
33-57: LGTM!core/src/main/java/com/orgmemory/core/assetregistry/skill/SkillPackageValidationException.java (1)
1-6: 🎯 Functional CorrectnessNo action needed. All references to
SkillPackageValidationExceptionare withincom.orgmemory.core.assetregistry.skill.
1 participant
Summary
assetregistry.skillas the bounded Skill semantics moduleVerification
./gradlew.bat clean test --no-daemon --max-workers=1(99 tasks; 1,265 tests; zero failures/errors/skips)python scripts/check_docs.py(534 Markdown files; 8 mirrored domain pairs)corepack pnpm release:checkon Node 24.15.0 (18 product + 23 policy tests)skip-release: intermediate modular refactor; release follows completion of the full refactor goal
Summary by CodeRabbit
New Features
Bug Fixes
Documentation